Skip to content

Mistakes in exception handling HybridConnectionListener #71

@consultantleon

Description

@consultantleon

We noticed a race condition occurring after a network disruption, the HybridConnectionListener continues to loop and does not properly detect the error and commence a fresh reconnection cycle.

The reason seems to be in the wrong runtime exceptions being caught in HybridConnectionListener.java.

I also removed all unnecessary throws and replaced catch(Throwable) by more specific exception after having run the code agains our sonar setup.

I advised our Microsoft representative to run your code against a standard code checking tool such as Sonar to take this kind of mistakes out the code! See attached my version of HybridConnectionListener.java - which we updated after your dev commit of Feb 7 (== 0.3 release version).
HybridConnectionListener.java.txt

Metadata

Metadata

Labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions