fix: correct GOST 28147 algorithm names#921
Merged
stevespringett merged 2 commits intoMay 21, 2026
Merged
Conversation
Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
bhess
approved these changes
May 5, 2026
stevespringett
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects misspelled GOST 28147 algorithm patterns in
schema/cryptography-defs.json.Changes
Updates:
GOST38147[-{mode}][-{padding}]toGOST28147[-{mode}][-{padding}]GOST38147_MACtoGOST28147_MACRationale
RFC 4357 defines the block cipher as GOST 28147-89. The previous patterns used
38147, which appears to be a typo.Validation
Validated
schema/cryptography-defs.jsonVerified no
GOST38147references remain underschemaFixes #920