Performance when changing LP data

[smharwood]

Potential performance improvements when changing LP data (costs, row and column bounds)

In particular, this avoids re-allocating local copies of data and re-sorting index sets

[jajhall]

I'll look at this again, and thanks for submitting the PR, but my instinct is that the overhead you're avoiding doesn't justify the additional code complexity: solving the modified problem is very much more expensive than performing the modification with the local copy

[smharwood]

Thanks for taking a look - the "repeated sort" is what caught my eye when I was profiling one of my problems.

I'll see if I can come up with an example that I can share that captures the behavior I'm seeing.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.33%. Comparing base (946a7bb) to head (afad16b).
⚠️ Report is 200 commits behind head on latest.

Additional details and impacted files

@@           Coverage Diff           @@
##           latest    #2813   +/-   ##
=======================================
  Coverage   80.33%   80.33%           
=======================================
  Files         348      348           
  Lines       86084    86109   +25     
=======================================
+ Hits        69152    69175   +23     
- Misses      16932    16934    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[smharwood]

Been meaning to say for the past month or two - this is not a priority for me anymore. I still think it could be a bottleneck, but I agree overall its probably not worth the effort. I'll close the PR, but who knows - might revisit.