Moving nested folders does not cleanup after move operation

[piu130]

Checklist

• I can reproduce the bug with the latest version given here.
• I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected app version

1.0.1

Affected Android/Custom ROM version

LineageOS 21

Affected device model

OnePlus 6

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

• Create a folder a and b.
• Create a folder c inside a folder b.
• Create a file d.txt inside folder c. (./b/c/d.txt).
• Move folder ./b to ./a.

Expected behavior

Folder structure of . is ./a/b/c/d.txt.

Actual behavior

Folder structure of . is ./a/b/c/d.txt but ./b/c still exists.
./b and ./b/c should be removed after the moving operation.

Screenshots/Screen recordings

No response

Additional information

When moving a folder with depth one (eg. ./a/b.txt) the folder (./a) is removed and it works correctly.

[duttyend]

I've just experienced the exact same thing.

[jguegel]

@piu130 @duttyend could you try to reproduce the issue within my branch? it should be fixed

[duttyend]

Thanks a lot @jguegel for addressing this annoying issue! Do you have any apk for us to test?

[jguegel]

you could try to build the PR: #276
or download the debug-apk: https://drive.google.com/file/d/1rWwlSIHycGdB0LNzv9-WSCmMWQoVp9YN/view?usp=sharing

[naveensingh]

I have triggered a build. An APK should be available soon under the checks tab:

https://github.com/FossifyOrg/File-Manager/actions/runs/18071955489/artifacts/4124999648

[duttyend]

@naveensingh @jguegel It works perfectly on my side! Thanks a lot!

[piu130]

Thanks for the fix :) seems good to me too.

[duttyend]

@naveensingh @jguegel I noticed the bug still exists when a folder contains subfolders.
How to recreate:

• create folder 1 somewhere,
• create folder 2 inside folder 1,
• move folder 1 elsewhere.
  Result: folder 1 and its nested folder 2 haven't been deleted in original location.

[naveensingh]

@duttyend, you were using the test build from above, correct?

[duttyend]

@duttyend, you were using the test build from above, correct?

Oh sorry, I was using the latest version (1.4.0). I've just tried again with the test build above (1.2.3) and it works fine.
Could you merge the fix into the next update?

[naveensingh]

Yeah, I'll check it soon.