Local Reviews (via API and Croissant)#12425
Open
pdurbin wants to merge 10 commits into
Open
Conversation
github-actions
Bot
added
Croissant
Closed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // "maxValue": 10 | ||
| // } | ||
| // }, | ||
| // ] |
There was a problem hiding this comment.
🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
File contains tab characters (this is the first instance).
pdurbin
force-pushed
the
12313-local-reviews-croissant
branch
from
613d452 to
d6f93f6
Compare
|
coverage: 25.08% (+0.01%) from 25.067% — 12313-local-reviews-croissant into develop |
This comment has been minimized.
This comment has been minimized.
tests/verify_mdb_properties.sh now passes
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
stevenwinship
approved these changes
Jun 4, 2026
stevenwinship
left a comment
stevenwinship
left a comment
Contributor
There was a problem hiding this comment.
Approved. Code looks good. Docs look good. I also tested using ReviewsIT in docker deployed environment after loading both tsv files, updating solr schema, and enabling the feature flag.
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
This was referenced Jun 5, 2026
pdurbin
added
Size: 10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We want to support local reviews, which is when a review dataset points at a regular dataset and both are in the same installation of Dataverse.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
In Docker, set DATAVERSE_FEATURE_CROISSANT_WITH_LOCAL_REVIEWS to "1" (or use the JVM equivalent).
Create a dataset like this:
Then, create a review dataset that points to the dataset like this:
Then try the new "list reviews" API endpoint.
Then download the Croissant for the dataset being reviewed. It should contain the review. This Croissant should be in the "head" of the HTML as well.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
Preview at https://dataverse-guide--12327.org.readthedocs.build/en/12327/api/native-api.html#list-reviews
In the image below (source) ReviewDataset2 is a local review: