Skip to content

Void[] breaks the parser before even invoking anything #5120

@dodexahedron

Description

@dodexahedron

Prerequisites

Exception report

Oops, something went wrong.
Please report this bug with ALL the details below, including both the 'Environment' and 'Exception' sections.
Please report on GitHub: https://github.com/PowerShell/PSReadLine/issues/new?template=Bug_Report.yaml
Thank you!

### Environment
PSReadLine: 2.4.5
PowerShell: 7.6.0
OS: Microsoft Windows 10.0.26220
BufferWidth: 291
BufferHeight: 80

Last 7 Keys:

 [ v o i d [ ]

### Exception

System.TypeLoadException: Could not create array type 'System.Void[]' from assembly 'System.Private.CoreLib, Version=10.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e' because the element type is System.Void.
   at System.RuntimeTypeHandle.MakeSZArray()
   at System.RuntimeType.MakeArrayType()
   at System.Management.Automation.Language.ArrayTypeName.GetReflectionType()
   at System.Management.Automation.Language.SymbolResolver.VisitArrayTypeName(ArrayTypeName arrayTypeName)
   at System.Management.Automation.Language.SymbolResolver.VisitTypeExpression(TypeExpressionAst typeExpressionAst)
   at System.Management.Automation.Language.TypeExpressionAst.InternalVisit(AstVisitor visitor)
   at System.Management.Automation.Language.CommandExpressionAst.InternalVisit(AstVisitor visitor)
   at System.Management.Automation.Language.PipelineAst.InternalVisit(AstVisitor visitor)
   at System.Management.Automation.Language.StatementBlockAst.InternalVisit(AstVisitor visitor, ReadOnlyCollection`1 traps, ReadOnlyCollection`1 statements, AstVisitAction action)
   at System.Management.Automation.Language.NamedBlockAst.InternalVisit(AstVisitor visitor)
   at System.Management.Automation.Language.ScriptBlockAst.InternalVisit(AstVisitor visitor)
   at System.Management.Automation.Language.Ast.Visit(AstVisitor astVisitor)
   at System.Management.Automation.Language.SymbolResolver.ResolveSymbols(Parser parser, ScriptBlockAst scriptBlockAst)
   at System.Management.Automation.Language.ScriptBlockAst.PerformPostParseChecks(Parser parser)
   at System.Management.Automation.Language.Parser.ParseTask(String fileName, String input, List`1 tokenList, Boolean recursed, ParseMode parseMode)
   at System.Management.Automation.Language.Parser.ParseInput(String input, String fileName, Token[]& tokens, ParseError[]& errors)

Screenshot

Image

Environment data

PS Version: 7.6.0
PS HostName: ConsoleHost (Windows Terminal)
PSReadLine Version: 2.4.5
PSReadLine EditMode: Windows
OS: 10.0.26100.7934 (WinBuild.160101.0800)
BufferWidth: 291
BufferHeight: 80

Steps to reproduce

First: Yes, Void[] is an illegal type in .net, since void can't be an array member.

However, it seems the parser is unable to gracefully handle it, in some cases (such as the above sequence).

It fails every time if entered as above, and in several other permutations I tried, such as using arrow keys to go back and edit the brackets in...But only in certain cases.

However, it also behaves slightly differently if there is already something else in the history buffer, AND it loses part of the key buffer in those cases, making the report misleading if taken directly. I played around with it a bit to try to suss out the specifics, but then figured that is probably pointless, since solving the root problem will almost definitely solve those cases at the same time, so gave up on that.

Expected behavior

Shouldn't die so quickly like this. Should be more graceful and not until invocation.

Actual behavior

Dies immediately on the keypress that completes the void[] type name.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Needs-Triage 🔍It's a new issue that core contributor team needs to triage.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions