Skip to content

[feat][ci]: verify bsp dist build#11419

Merged
Rbb666 merged 2 commits into
RT-Thread:masterfrom
CYFS3:feat_ci_dist
Jun 2, 2026
Merged

[feat][ci]: verify bsp dist build#11419
Rbb666 merged 2 commits into
RT-Thread:masterfrom
CYFS3:feat_ci_dist

Conversation

@CYFS3

@CYFS3 CYFS3 commented May 27, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

当前 bsp_buildings.yml 只验证了 BSP 原工程是否可以通过 scons 编译,但没有验证 scons --dist 打包后的分发工程是否仍然可以编译。这样如果打包逻辑漏拷文件、路径替换异常,或者生成的 dist/project 依赖了仓库根目录,CI 不容易及时发现问题。

你的解决方案是什么 (what is your solution)

  • 在 BSP 静态构建 CI 中增加 RTT_CI_BUILD_DIST 开关,用于启用分发包构建校验。
  • tools/ci/bsp_buildings.py 中新增 dist 校验流程:BSP 原工程编译成功后,执行 scons --dist -C bsp/<bsp>,然后进入生成的 dist/project 执行 scons --pyconfig-silentscons -j<nproc>
  • 编译 dist/project 时临时移除 RTT_ROOT 环境变量,确保验证的是打包出来的 rt-thread/ 目录,而不是误用仓库根目录。
  • dist 校验结果会写入 GitHub Step Summary;校验完成后清理 dist/ 目录,避免影响后续构建或产物上传。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

CI 脚本级改动,未针对单个 BSP 修改配置。该校验会随 bsp_buildings.yml 的 matrix 对本次需要编译的 BSP 生效。

  • .config:

未修改 BSP .config

  • action:

本地已完成以下检查:

python -m py_compile tools/ci/bsp_buildings.py
git diff --check -- .github/workflows/bsp_buildings.yml tools/ci/bsp_buildings.py

PR 提交后由 GitHub Actions 自动运行 BSP 静态构建检查。
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:feat_ci_dist
  • 设置PR number为 \ Set the PR number to:11419
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 feat_ci_dist 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the feat_ci_dist branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added action github action yml imporve tools labels May 27, 2026
@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_hc32

Reviewers: levizh

Changed Files (Click to expand)
  • bsp/hc32/tools/sdk_dist.py

🏷️ Tag: bsp_mm32f526x

Reviewers: Maihuanyi

Changed Files (Click to expand)
  • bsp/mm32/mm32f526x/.config
  • bsp/mm32/mm32f526x/SConstruct

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/workflows/bsp_buildings.yml

📊 Current Review Status (Last Updated: 2026-05-28 14:46 CST)

  • Maihuanyi Pending Review
  • Rbb666 Pending Review
  • kurisaW Pending Review
  • levizh Pending Review
  • supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@CYFS3 CYFS3 requested a review from Rbb666 as a code owner May 27, 2026 13:00
@github-actions github-actions Bot added BSP: NXP Code related with NXP BSP: STM32 BSP related with ST/STM32 BSP BSP: Infineon BSP related with Infineon BSP: AT32 BSP related with AT32 BSP: WCH BSP related with WCH labels May 27, 2026
@Rbb666 Rbb666 merged commit f7a6986 into RT-Thread:master Jun 2, 2026
79 checks passed
@CYFS3 CYFS3 deleted the feat_ci_dist branch June 8, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve BSP: AT32 BSP related with AT32 BSP: Infineon BSP related with Infineon BSP: NXP Code related with NXP BSP: STM32 BSP related with ST/STM32 BSP: WCH BSP related with WCH BSP tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants