fix(@angular/build): ensure transitive SCSS partial errors are tracked in watch mode#32883
Conversation
…d in watch mode When stylesheet bundling fails due to an error in a SCSS partial, we now ensure that `referencedFiles` are still passed to the `FileReferenceTracker`. This prevents the dependency between the component and the error file from being lost, allowing the component to be correctly rebuilt when the error is fixed.
clydin
added
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request ensures that stylesheet dependencies are tracked even when compilation errors occur, allowing for correct rebuilds once errors are resolved. It adds logic to the Angular compiler plugin to track referenced files in error states and includes regression tests for transitive and deep transitive imports. Review feedback suggests refactoring the new tests into a data-driven loop and consolidating the file tracking logic to avoid duplication between the success and error code paths.
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
When stylesheet bundling fails due to an error in a SCSS partial, we now ensure that
referencedFilesare still passed to theFileReferenceTracker. This prevents the dependency between the component and the error file from being lost, allowing the component to be correctly rebuilt when the error is fixed.