fix(@schematics/angular): add trusted-proxy-headers migration#33065
Conversation
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new schematic migration, trusted-proxy-headers, designed to automatically add the trustProxyHeaders configuration to AngularAppEngine or AngularNodeAppEngine instantiations within server.ts files. The migration also inserts a security-sensitive TODO comment to guide developers. Review feedback identifies a potential syntax error when the migration encounters new expressions without parentheses and suggests improving the detection of existing properties by accounting for string literal keys in object literals.
alan-agius4
force-pushed
the
migration-trusted
branch
3 times, most recently
from
a55328e to
397f73d
Compare
Adds a new schematic migration to automatically add trustProxyHeaders configuration to server.ts files in workspaces where either AngularNodeAppEngine or AngularAppEngine are used.
alan-agius4
force-pushed
the
migration-trusted
branch
from
397f73d to
579f0e4
Compare
alan-agius4
added
action: merge
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
Adds a new schematic migration to automatically add trustProxyHeaders configuration to server.ts files in workspaces where either AngularNodeAppEngine or AngularAppEngine are used.