-
Notifications
You must be signed in to change notification settings - Fork 134
chore: remove stale Skyfire-specific utilities after PaymentProvider refactor #604
Copy link
Copy link
Open
Labels
t-aiIssues owned by the AI team.Issues owned by the AI team.
Description
Summary
Follow-up cleanup after the PaymentProvider refactor (#590). Several Skyfire-specific standalone functions are now superseded by methods on SkyfirePaymentProvider and should be removed.
Changes
- Remove
redactSkyfirePayIdfromsrc/utils/logging.ts— superseded bySkyfirePaymentProvider.redactForLogging()on the provider interface; remove deprecated re-export fromindex_internals.ts - Remove dead
applySkyfireAugmentation/isSkyfireEligiblefromsrc/utils/tools.ts— superseded bySkyfirePaymentProvider.decorateToolSchema() - Replace Skyfire-specific comments/messages with provider-agnostic wording in
call_actor_common.ts,actor_execution.ts,actor_tools_factory.ts, andactor_details.ts - Update unit tests to target
SkyfirePaymentProvider.redactForLogging()anddecorateToolSchema()instead of the removed standalone functions
Notes
redactSkyfirePayIdis currently still exported fromindex_internals.tsfor backward compatibility withapify-mcp-server-internal. Coordinate removal with an update to the internal repo.- In
actor_execution.ts, theinputpassed tocallActorGetDatasetis alreadypayment.cleanArgs(payment fields stripped bypreparePayment()), so no redaction call is needed there at all.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
t-aiIssues owned by the AI team.Issues owned by the AI team.
Type
Fields
Give feedbackNo fields configured for issues without a type.