Add SQLAlchemy ORM plugin tests#1235
Open
jonathanl-bq wants to merge 43 commits into
Open
Conversation
karenc-bq
reviewed
May 19, 2026
| else: | ||
| opts['plugins'] = opts['wrapper_plugins'] | ||
| opts.pop('wrapper_plugins', None) | ||
| if 'connect_timeout' in opts: |
Contributor
There was a problem hiding this comment.
Do we also need to check for other timeouts here
Author
There was a problem hiding this comment.
The other timeouts set in the plugins tests (e.g. socket_timeout, monitoring-connect_timeout, monitoring-socket_timeout) don't seem to cause any problems.
karenc-bq
reviewed
May 19, 2026
| ) | ||
|
|
||
| self.supports_sequences = ( | ||
| self.is_mariadb and self.server_version_info >= (10, 3) |
Contributor
There was a problem hiding this comment.
Curious why are we checking mariadb here?
Author
There was a problem hiding this comment.
I didn't want to change too much of the existing logic this was based on from sqlalchemy.
karenc-bq
reviewed
May 22, 2026
| if 'target' not in opts: | ||
| opts['target'] = mysql.connector.Connect | ||
| if 'wrapper_plugins' not in opts: | ||
| opts['plugins'] = "aurora_connection_tracker,failover" |
Contributor
There was a problem hiding this comment.
can we switch the default plugin list to using failover2 instead of failover1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds the SQLAlchemy ORM plugin tests, and also updates the
mysql_orm_dialectto intercept calls to the underlying driver.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.