-
Notifications
You must be signed in to change notification settings - Fork 80
Simplify ConnectionConfig — remove url and proxyConnection #1622
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Parent PRD
What to build
Remove url and proxyConnection from ConnectionConfig and NormalizedConnection types. Make graphDbUrl required. Simplify normalizeConnection to remove the proxy inference logic. Update fetchDatabaseRequest/getAuthHeaders to always send proxy headers (graph-db-connection-url, db-query-logging-enabled) unconditionally.
This is the core type change that cascades through the codebase, eliminating conditional branches around proxy vs direct connections.
Type: HITL — requires review before completion.
Acceptance criteria
-
ConnectionConfigno longer hasurlorproxyConnectionfields -
graphDbUrlis required onConnectionConfig -
NormalizedConnectionreflects the simplified type -
normalizeConnectionno longer infersproxyConnection -
getAuthHeadersalways sendsgraph-db-connection-urlanddb-query-logging-enabledheaders - All type errors resolved across the codebase
- Tests for
normalizeConnectionupdated - Tests for
fetchDatabaseRequest/getAuthHeadersverify headers are always sent
Blocked by
User stories addressed
- User story 10
- User story 15
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request