Commit 3bf5912
Pravali Uppugunduri
Fix Triton HMAC security vulnerabilities (v2)
- Bug 1: Add HMAC integrity check before pickle deserialization in
Triton handler initialize() method (model.py)
- Bug 2: Replace hardcoded secret key with generate_secret_key() and
add _hmac_signing() after ONNX exports (triton_builder.py)
- Bug 3: Add secret key validation in _start_triton_server() to reject
empty/None keys before passing to container (server.py)
Aligns Triton code path with existing HMAC verification patterns used
by TorchServe, MMS, TF Serving, and SMD handlers.
Ticket: P4001360881 parent e5f349c commit 3bf5912
File tree
3 files changed
+16
-3
lines changed- src/sagemaker/serve/model_server/triton
3 files changed
+16
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
29 | 31 | | |
30 | | - | |
| 32 | + | |
| 33 | + | |
31 | 34 | | |
32 | | - | |
| 35 | + | |
| 36 | + | |
33 | 37 | | |
34 | 38 | | |
35 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
41 | 48 | | |
42 | 49 | | |
43 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
216 | | - | |
| 216 | + | |
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
| 222 | + | |
222 | 223 | | |
223 | 224 | | |
224 | 225 | | |
225 | 226 | | |
226 | 227 | | |
227 | 228 | | |
| 229 | + | |
228 | 230 | | |
229 | 231 | | |
230 | 232 | | |
| |||
0 commit comments