Update remote function serialization/deserialization logic to use asymmetric keys for data verification checks#5708
Merged
Merged
Conversation
mollyheamazon
left a comment
mollyheamazon
left a comment
Contributor
There was a problem hiding this comment.
Please add detailed description on this PR
mollyheamazon
previously approved these changes
Apr 1, 2026
rohangujarathi
left a comment
rohangujarathi
left a comment
Member
There was a problem hiding this comment.
- It looks like a significant amount of changes in this PR are related to formatting and whitespace changes. Can we leave those changes out of this PR?
- Remote function related integ tests are failing. Are we fixing those?
Comment on lines
+581
to
+582
| @pytest.mark.skip | ||
| def test_decorator_auto_capture(sagemaker_session, auto_capture_test_container): |
Member
Author
There was a problem hiding this comment.
mnuyens
approved these changes
Apr 2, 2026
rohangujarathi
previously approved these changes
Apr 2, 2026
added 5 commits
April 8, 2026 16:18
This reverts commit fb0d789.
mollyheamazon
approved these changes
Apr 9, 2026
Evan-W-ang
added a commit
to Evan-W-ang/sagemaker-python-sdk
that referenced
this pull request
Jun 8, 2026
…mmetric keys for data verification checks (aws#5708) * Revert "Bug fix for hmac key for V3 (aws#5379)" This reverts commit fb0d789. * Revert "Add sagemaker dependency for remote function by default V3 (aws#5487)" This reverts commit 422b35f. * fix: use asymmetric keys to sign remote function signature * chore: migrate remote_function integ tests from V2 * fix: rename signing key --------- Co-authored-by: Namrata Madan <nmmadan@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.