Skip to content

chore: bump llama.cpp to b9501#955

Merged
ericcurtin merged 1 commit into
mainfrom
bump-llamacpp-b9501
Jun 4, 2026
Merged

chore: bump llama.cpp to b9501#955
ericcurtin merged 1 commit into
mainfrom
bump-llamacpp-b9501

Conversation

@ilopezluna

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Ignacio López Luna <ignasi.lopez.luna@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the llama.cpp server version from b8967 to b9501, modifying the .versions file, Dockerfile, and the vendor subproject commit. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="Dockerfile" line_range="3-6" />
<code_context>

 ARG GO_VERSION=1.25
-ARG LLAMA_SERVER_VERSION=b8967
+ARG LLAMA_SERVER_VERSION=b9501
 ARG LLAMA_SERVER_VARIANT=cpu
-ARG LLAMA_UPSTREAM_IMAGE=ghcr.io/ggml-org/llama.cpp:server-vulkan-b8967
+ARG LLAMA_UPSTREAM_IMAGE=ghcr.io/ggml-org/llama.cpp:server-vulkan-b9501

 ARG VERSION=dev
</code_context>
<issue_to_address>
**suggestion:** Avoid duplicating the version string by deriving LLAMA_UPSTREAM_IMAGE from LLAMA_SERVER_VERSION.

`b9501` is currently duplicated in both `LLAMA_SERVER_VERSION` and `LLAMA_UPSTREAM_IMAGE`, which makes version bumps error-prone. Instead, compose `LLAMA_UPSTREAM_IMAGE` from `LLAMA_SERVER_VERSION`, e.g.:

```dockerfile
ARG LLAMA_SERVER_VERSION=b9501
ARG LLAMA_SERVER_VARIANT=cpu
ARG LLAMA_UPSTREAM_BASE=ghcr.io/ggml-org/llama.cpp
ARG LLAMA_UPSTREAM_IMAGE=${LLAMA_UPSTREAM_BASE}:server-vulkan-${LLAMA_SERVER_VERSION}
```

This keeps the version in a single place and avoids mismatches on future updates.

```suggestion
ARG GO_VERSION=1.25
ARG LLAMA_SERVER_VERSION=b9501
ARG LLAMA_SERVER_VARIANT=cpu
ARG LLAMA_UPSTREAM_BASE=ghcr.io/ggml-org/llama.cpp
ARG LLAMA_UPSTREAM_IMAGE=${LLAMA_UPSTREAM_BASE}:server-vulkan-${LLAMA_SERVER_VERSION}
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread Dockerfile
Comment on lines 3 to +6
ARG GO_VERSION=1.25
ARG LLAMA_SERVER_VERSION=b8967
ARG LLAMA_SERVER_VERSION=b9501
ARG LLAMA_SERVER_VARIANT=cpu
ARG LLAMA_UPSTREAM_IMAGE=ghcr.io/ggml-org/llama.cpp:server-vulkan-b8967
ARG LLAMA_UPSTREAM_IMAGE=ghcr.io/ggml-org/llama.cpp:server-vulkan-b9501

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Avoid duplicating the version string by deriving LLAMA_UPSTREAM_IMAGE from LLAMA_SERVER_VERSION.

b9501 is currently duplicated in both LLAMA_SERVER_VERSION and LLAMA_UPSTREAM_IMAGE, which makes version bumps error-prone. Instead, compose LLAMA_UPSTREAM_IMAGE from LLAMA_SERVER_VERSION, e.g.:

ARG LLAMA_SERVER_VERSION=b9501
ARG LLAMA_SERVER_VARIANT=cpu
ARG LLAMA_UPSTREAM_BASE=ghcr.io/ggml-org/llama.cpp
ARG LLAMA_UPSTREAM_IMAGE=${LLAMA_UPSTREAM_BASE}:server-vulkan-${LLAMA_SERVER_VERSION}

This keeps the version in a single place and avoids mismatches on future updates.

Suggested change
ARG GO_VERSION=1.25
ARG LLAMA_SERVER_VERSION=b8967
ARG LLAMA_SERVER_VERSION=b9501
ARG LLAMA_SERVER_VARIANT=cpu
ARG LLAMA_UPSTREAM_IMAGE=ghcr.io/ggml-org/llama.cpp:server-vulkan-b8967
ARG LLAMA_UPSTREAM_IMAGE=ghcr.io/ggml-org/llama.cpp:server-vulkan-b9501
ARG GO_VERSION=1.25
ARG LLAMA_SERVER_VERSION=b9501
ARG LLAMA_SERVER_VARIANT=cpu
ARG LLAMA_UPSTREAM_BASE=ghcr.io/ggml-org/llama.cpp
ARG LLAMA_UPSTREAM_IMAGE=${LLAMA_UPSTREAM_BASE}:server-vulkan-${LLAMA_SERVER_VERSION}

Comment thread .versions
@@ -1 +1 @@
GO_VERSION=1.25

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do something about this file, manually editing this really isn't great

@ericcurtin ericcurtin merged commit 842fd45 into main Jun 4, 2026
14 checks passed
@ericcurtin ericcurtin deleted the bump-llamacpp-b9501 branch June 4, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants