Surface waiting ask_user tool calls in remote pendingToolCalls#493
Merged
ericdallo merged 2 commits intoJun 7, 2026
Merged
Conversation
A web/SSE client that reconnects rebuilds state via GET /api/v1/chats/:id, but a chat blocked on ask_user was invisible there: the tool call sits in :executing (not :waiting-approval) while its handler blocks on the answer, so pendingToolCalls never listed it and the client couldn't re-render the question. ask_user now mints its requestId up front, stores it in tool-call state, and passes it to the messenger so the SSE event and the persisted id match. pendingToolCalls includes :executing ask_user calls and carries requestId so a reconnecting client can answer via POST /api/v1/answer.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A web/SSE client that reconnects rebuilds state via GET /api/v1/chats/:id, but a chat blocked on ask_user was invisible there: the tool call sits in :executing (not :waiting-approval) while its handler blocks on the answer, so pendingToolCalls never listed it and the client couldn't re-render the question.
ask_user now mints its requestId up front, stores it in tool-call state, and passes it to the messenger so the SSE event and the persisted id match. pendingToolCalls includes :executing ask_user calls and carries requestId so a reconnecting client can answer via POST /api/v1/answer.