[Repo Assist] feat: add TaskSeq.findBack, tryFindBack, findIndexBack, tryFindIndexBack (and async variants)#374
Closed
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
…ync, findIndexBack, findIndexBackAsync, tryFindIndexBack, tryFindIndexBackAsync (273 tests) These functions find the last matching element or index, mirroring Seq.findBack, Seq.tryFindBack, Seq.findIndexBack, and Seq.tryFindIndexBack from FSharp.Core. Unlike their forward counterparts, they consume the entire sequence to locate the last match; this is documented in the signatures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
bot
added
automation
enhancement
Contributor
|
We don't need these for async sequences |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Summary
Adds eight new functions mirroring
Seq.findBack,Seq.tryFindBack,Seq.findIndexBack, andSeq.tryFindIndexBackfrom FSharp.Core:TaskSeq.tryFindBackNoneTaskSeq.tryFindBackAsyncTaskSeq.findBackKeyNotFoundExceptionif not foundTaskSeq.findBackAsyncTaskSeq.tryFindIndexBackNoneTaskSeq.tryFindIndexBackAsyncTaskSeq.findIndexBackTaskSeq.findIndexBackAsyncKey design decision
Unlike the forward variants (
find,findIndex), the*Backvariants always consume the entire sequence — they must scan to the end to determine which match is last. This is documented in the XML doc comments and tested explicitly.Implementation
TaskSeqInternal.fs: Two core functionstryFindBackandtryFindIndexBack. Both scan the full sequence using awhileloop, updating afoundItem/foundIndexmutable on every match.TaskSeq.fs: Eight public members; the throwing variants pipe throughTask.map (Option.defaultWith Internal.raiseNotFound)following the same pattern asfind/findIndex.TaskSeq.fsi: Full XML doc comments matching the project style.Test Status
dotnet build— succeeded, 0 warningsdotnet test— 5290 passed, 2 skipped (273 new; 2 skipped are pre-existing infrastructure-only skips)dotnet fantomas . --check— no issues