Skip to content

[TimePicker] Use Material3 icon-only style for input mode button#2932

Open
pubiqq wants to merge 1 commit into
material-components:masterfrom
pubiqq:timepicker/icon-only-input-mode
Open

[TimePicker] Use Material3 icon-only style for input mode button#2932
pubiqq wants to merge 1 commit into
material-components:masterfrom
pubiqq:timepicker/icon-only-input-mode

Conversation

@pubiqq

@pubiqq pubiqq commented Aug 22, 2022

Copy link
Copy Markdown
Contributor
Before After

@imhappi imhappi requested a review from paulfthomas August 24, 2022 17:11
@drchen

drchen commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

We probably need designer's approval for this. @paulfthomas can you give some suggestions how we should proceed here?

@paulfthomas

Copy link
Copy Markdown
Member

Can you explain the changes?

  • why removing the marginTop?
  • why removing the shapeAppearance?

@pubiqq

pubiqq commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

why removing the marginTop?

@id/barrier already provides the correct margin, additional "fine-tuning" is not needed.

why removing the shapeAppearance?

The correct and consistent shapeAppearance is provided by Widget.Material3.Button.

@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from 3101a47 to 73370af Compare May 15, 2023 18:28
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from 73370af to 3413f5a Compare August 24, 2023 01:57

@raajkumars raajkumars left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pubiqq pubiqq mentioned this pull request Oct 2, 2023
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from 3413f5a to db30136 Compare August 13, 2024 11:35
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from db30136 to e7bb570 Compare September 4, 2024 18:48
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from e7bb570 to 730c146 Compare May 12, 2025 20:22
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch 2 times, most recently from 345ede2 to 4d83f03 Compare June 27, 2025 16:43
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from 4d83f03 to 8f4f083 Compare August 7, 2025 17:49
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from 8f4f083 to 4b3f924 Compare August 29, 2025 17:57
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from 4b3f924 to 7ce9662 Compare September 8, 2025 20:37
@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from 7ce9662 to ab123d3 Compare March 17, 2026 15:09
@pubiqq

pubiqq commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Bump

@pubiqq pubiqq force-pushed the timepicker/icon-only-input-mode branch from ab123d3 to e633778 Compare May 26, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants