Mark AOAI user message AddTextPart/AddFilePart as OnPrem and GenerateChatCompletion impl overload as NonDebuggable#8186
Merged
Conversation
…ChatCompletion impl overload as NonDebuggable Fixes AB#635890 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 18, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mynjj
previously approved these changes
May 18, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
qutreson
approved these changes
May 18, 2026
WaelAbuSeada
approved these changes
May 18, 2026
Groenbech96
added a commit
that referenced
this pull request
May 18, 2026
…enerateChatCompletion impl overload as NonDebuggable (#8187) Backport of #8186 to releases/28.0. ## Summary - Add `[Scope('OnPrem')]` to `AddTextPart` and `AddFilePart` on the `AOAI User Message` codeunit. - Add `[NonDebuggable]` to the second `GenerateChatCompletion` overload in `Azure OpenAI Impl`. Fixes [AB#635891](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/635891) --------- Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Groenbech96
added a commit
that referenced
this pull request
May 18, 2026
…enerateChatCompletion impl overload as NonDebuggable (#8188) Backport of #8186 to releases/28.1. ## Summary - Add `[Scope('OnPrem')]` to `AddTextPart` and `AddFilePart` on the `AOAI User Message` codeunit. - Add `[NonDebuggable]` to the second `GenerateChatCompletion` overload in `Azure OpenAI Impl`. Fixes [AB#635892](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/635892) --------- Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Groenbech96
added a commit
that referenced
this pull request
May 18, 2026
…enerateChatCompletion impl overload as NonDebuggable (#8189) Backport of #8186 to releases/28.x. ## Summary - Add `[Scope('OnPrem')]` to `AddTextPart` and `AddFilePart` on the `AOAI User Message` codeunit. - Add `[NonDebuggable]` to the second `GenerateChatCompletion` overload in `Azure OpenAI Impl`. Fixes [AB#635893](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/635893) --------- Co-authored-by: Magnus Hartvig Grønbech <magnushar@microsoft.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Scope('OnPrem')]toAddTextPartandAddFileParton theAOAI User Messagecodeunit.[NonDebuggable]to the secondGenerateChatCompletionoverload inAzure OpenAI Impl, matching the first overload and the public-facing ones inAzure OpenAI.Fixes AB#635890