Skip to content

Properly initialize AEAD cipher flags in OpenSSL backend#20853

Open
jordikroon wants to merge 6 commits intophp:masterfrom
jordikroon:fix/gh20851
Open

Properly initialize AEAD cipher flags in OpenSSL backend#20853
jordikroon wants to merge 6 commits intophp:masterfrom
jordikroon:fix/gh20851

Conversation

@jordikroon
Copy link
Copy Markdown
Contributor

@jordikroon jordikroon commented Jan 6, 2026 •
edited
Loading

Fixes #20851

Add support for AEAD ciphers like AES-SIV by detecting and initializing AEAD flags during cipher mode loading.
Includes test case for AES-256-SIV encryption/decryption roundtrip.

@jordikroon jordikroon requested a review from bukka as a code owner January 6, 2026 22:38
@jordikroon jordikroon changed the title properly initialize AEAD cipher flags in OpenSSL backend Properly initialize AEAD cipher flags in OpenSSL backend Jan 6, 2026
@jordikroon jordikroon requested a review from kocsismate as a code owner January 7, 2026 19:09
@jordikroon
Copy link
Copy Markdown
Contributor Author

jordikroon commented Jan 7, 2026

Please review commits 1 by 1 since I am not sure if the change from string $aad = "" to ?string $aad = "" is acceptable.
The first commit only fixes SIV Synthetic Initialization Vector where it generates its own IV. It was not respected.

The second commit allows AAD to be null since it behaves differently than when only an empty string is given. The matches other implementations like cryptography in python.

bukka
bukka reviewed Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. Just some minor things really.

bukka
bukka reviewed Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good now. It would be just nice to convert the test so it's consistent with other AEAD tests.

@onyn
Copy link
Copy Markdown

onyn commented Jan 23, 2026

Note that openssl supports aes-gcm-siv since v3.2 which is improved version of aes-siv. Is it possible to add support for aes-gcm-siv here in advance?

@bukka
Copy link
Copy Markdown
Member

bukka commented Apr 3, 2026

The code looks good but it needs rebase...

@jordikroon
Copy link
Copy Markdown
Contributor Author

jordikroon commented Apr 7, 2026

@bukka This has been rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bukka bukka bukka approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees

No one assigned

Labels

Extension: openssl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AES SIV cipher algorithms implemented incorrectly in openssl module

4 participants

@jordikroon @onyn @bukka @iluuu1994