Fix GH-22112: assertion when error handler throws during NaN coercion#22114
Open
iliaal wants to merge 1 commit into
Open
Fix GH-22112: assertion when error handler throws during NaN coercion#22114iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
zend_parse_arg_bool_weak and zend_parse_arg_str_weak could return success with EG(exception) already set, because zend_is_true and convert_to_string emit the NaN coercion warning without checking whether the user error handler threw. Recv-arg verification for a userland function then took the no-check ZEND_VM_NEXT_OPCODE branch, aborting on ZEND_ASSERT(!EG(exception)). Mirror the existing check in zend_parse_arg_long_weak and propagate failure when the warning leaves an exception pending. Fixes phpGH-22112
Girgias
requested changes
May 24, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
This is likely a bug already in 8.5 so needs to be backported.
Also do not use exceptions defined in extensions when testing core functionality.
| <?php | ||
|
|
||
| set_error_handler(function ($errno, $errstr) { | ||
| throw new RuntimeException($errstr); |
Member
There was a problem hiding this comment.
Suggested change
| throw new RuntimeException($errstr); | |
| throw new Exception($errstr); |
Comment on lines
+20
to
+30
| try { | ||
| take_bool($nan); | ||
| } catch (RuntimeException $e) { | ||
| echo "bool: ", $e->getMessage(), "\n"; | ||
| } | ||
|
|
||
| try { | ||
| take_string($nan); | ||
| } catch (RuntimeException $e) { | ||
| echo "string: ", $e->getMessage(), "\n"; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| try { | |
| take_bool($nan); | |
| } catch (RuntimeException $e) { | |
| echo "bool: ", $e->getMessage(), "\n"; | |
| } | |
| try { | |
| take_string($nan); | |
| } catch (RuntimeException $e) { | |
| echo "string: ", $e->getMessage(), "\n"; | |
| } | |
| try { | |
| take_bool($nan); | |
| } catch (Exception $e) { | |
| echo "bool: ", $e->getMessage(), "\n"; | |
| } | |
| try { | |
| take_string($nan); | |
| } catch (Exception $e) { | |
| echo "string: ", $e->getMessage(), "\n"; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recv-arg verification for a userland function asserts
!EG(exception)after a successful weak coercion.zend_parse_arg_bool_weakandzend_parse_arg_str_weakreturned success without checking whether the NaN-coerced-to-bool/string warning had triggered a throw from the user error handler. Mirror the post-warning check inzend_parse_arg_long_weak.Fixes #22112