Skip to content

chore: update Peer Dependencies for React#125

Open
feddyups wants to merge 1 commit into
praneshr:masterfrom
feddyups:patch-1
Open

chore: update Peer Dependencies for React#125
feddyups wants to merge 1 commit into
praneshr:masterfrom
feddyups:patch-1

Conversation

@feddyups

@feddyups feddyups commented Jun 9, 2021

Copy link
Copy Markdown

Update Peer Dependencies for React

@feddyups
Update Peer Dependencies for React
9c49a58 
Update Peer Dependencies for React
e0ne
e0ne approved these changes Jun 9, 2021
View reviewed changes

@e0ne e0ne left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be good to release with this change

@feddyups feddyups changed the title Update Peer Dependencies for React chore: update Peer Dependencies for React Jun 10, 2021
@schmave

schmave commented Jun 23, 2021

Copy link
Copy Markdown

Tests pass locally when using React 17, though you have to install @wojtekmaj/enzyme-adapter-react-17 as an enzyme adapter in order to get them to work. (Enzyme doesn't yet officially support React 17).

@yeikel

yeikel commented Oct 18, 2021

Copy link
Copy Markdown

Hi team,

What is blocking this change?

@kad-stokkt

kad-stokkt commented Nov 18, 2021 •
edited
Loading

Copy link
Copy Markdown

approval as a subtle nudge ;)

@iamursky

iamursky commented Dec 27, 2021

Copy link
Copy Markdown

up

@feddyups

feddyups commented Jan 10, 2022

Copy link
Copy Markdown
Author

Is this project still alive? Should we try with a fork or something? Ideally before we move to React 18?

@plamenkoyovchev

plamenkoyovchev commented Jan 17, 2022

Copy link
Copy Markdown

Come on guys! Let's merge this thing :) A lot of people need it.

@stsmurf

stsmurf commented Feb 2, 2022

Copy link
Copy Markdown

+1

@iamursky

iamursky commented May 13, 2022

Copy link
Copy Markdown

+1

@nimesulide

nimesulide commented Jun 7, 2022

Copy link
Copy Markdown

@praneshr could you please merge this PR?

@guy-har guy-har mentioned this pull request Jun 9, 2022
Closed
@nagarciah

nagarciah commented Jun 21, 2022

Copy link
Copy Markdown

Hello @praneshr . I've been using this library with React 17 for months now and I can confirm it works fine. I would be glad to help you if there is still anything missing to merge this PR. How may I help?

@nnikitos95

nnikitos95 commented Jul 29, 2022

Copy link
Copy Markdown

Hi, guys, what about merge and closing this issue?

@talSofer

talSofer commented Aug 22, 2022

Copy link
Copy Markdown

Hi, any estimation on when this issue will be resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

10 more reviewers

@e0ne e0ne e0ne approved these changes

@garyantoriano garyantoriano garyantoriano approved these changes

@nimesulide nimesulide nimesulide approved these changes

@michael1997 michael1997 michael1997 approved these changes

@CruseCtrl CruseCtrl CruseCtrl approved these changes

@Allwithyou999 Allwithyou999 Allwithyou999 approved these changes

@iamursky iamursky iamursky approved these changes

@mathgeek12 mathgeek12 mathgeek12 approved these changes

@KitaharaMugiro KitaharaMugiro KitaharaMugiro approved these changes

@kad-stokkt kad-stokkt kad-stokkt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.