Skip to content

chore: extract main into an embeddable app package #5259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siavashs wants to merge 15 commits into
base: main
Choose a base branch
from
Open

chore: extract main into an embeddable app package #5259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fc34ac5
cmd/alertmanager: extract main into internal/app package
siavashs May 29, 2026
e0b7423
internal/app: add App lifecycle (New/Start/Addr/Reload/Stop)
siavashs May 29, 2026
aa7ce25
address commend and add more tests
siavashs Jun 4, 2026
996d22f
address rabbit comments
siavashs Jun 5, 2026
1822852
internal/app: isolate reload-scoped lifecycle and harden teardown
siavashs Jun 5, 2026
fa59937
fix lint issues
siavashs Jun 5, 2026
a6c287c
fix potential peer leak on setup failure
siavashs Jun 5, 2026
0719a48
fix partial config apply on failed reload
siavashs Jun 5, 2026
6edf3c3
fix opts.Reload hot-loop for embedders
siavashs Jun 5, 2026
2d3d6b4
publish the new inhibitor only after it has finished loading
siavashs Jun 5, 2026
8c76b21
minor restructure and nits
siavashs Jun 5, 2026
5812d7b
fix lint
siavashs Jun 5, 2026
c418b1a
address comments
siavashs Jun 8, 2026
6eba13a
allow cluster ssttle timeout 0
siavashs Jun 8, 2026
646cb62
address comments
siavashs Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ Alertmanager handles alerts sent by clients such as Prometheus. It deduplicates,

Top‑level packages worth knowing:

- `cmd/alertmanager/` — main binary entry point (`main.go`).
- `cmd/alertmanager/` — main binary entry point (`main.go`); thin wrapper that parses flags and calls `app`.
- `app/` — embeddable Alertmanager runtime extracted from `cmd/alertmanager`. Owns the process lifecycle (`New`/`Start`/`Stop`/`Reload`/`Run`), subsystem wiring (`setup`), config-reload subgraph (`reloader`), listeners and `Options`. Lets tests and other binaries run Alertmanager in‑process. See https://github.com/prometheus/alertmanager/issues/406.
- `cmd/amtool/` — CLI for interacting with the Alertmanager API.
- `api/` — HTTP API. `api/v2/` is the active API; `api/v1_deprecation_router.go` only returns deprecation responses.
- `cli/` — `amtool` command implementations.
Expand Down
Loading