Skip to content

fix: resolve environment test quality findings#45

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/fix-quality-findings
May 18, 2026
Merged

fix: resolve environment test quality findings#45
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/fix-quality-findings

Conversation

@mldangelo-oai
Copy link
Copy Markdown
Contributor

Summary

  • simplify the Pop!_OS distro-detection test so it reads the real temp fixture directly
  • remove the duplicate fixture payload and the misleading unused Path shim
  • delete the dead local helper flagged by CodeQL in the /usr/lib/os-release fallback test

Why

GitHub Security and quality currently reports two AI findings plus one standard CodeQL maintainability finding in tests/test_environment.py. These are test-only cleanup issues, so this PR resolves them without changing runtime behavior.

Validation

  • uv run pytest tests/test_environment.py
  • uv run pytest -m 'not smoke'
  • uv run ruff check tests/test_environment.py
  • git diff --check

@mldangelo-oai mldangelo-oai marked this pull request as ready for review May 18, 2026 18:39
@mldangelo-oai mldangelo-oai merged commit 879bb2a into main May 18, 2026
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant