perf: avoid utf8 conversion when appending extensions#218
Draft
hardfist wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out the first resolver micro-optimization from #215.
This keeps extension probing on Unix in
OsStrbyte form when appending configured extensions, avoiding a lossy UTF-8 string conversion on the normal file-extension lookup path.Measurement
Measured previously against exact Callgrind for:
Baseline:
116,917,041IrAfter this change:
116,554,214IrDelta:
-362,827Ir (-0.31%)Artifact from the original measurement run:
Validation
cargo clippy --all-features -- -D warnings cargo test --lib -- --skip tests::pnp