fix(BlogList): support arbitrary locale for date formatting#96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The BlogList component accepts a
langprop, but date formatting ignores it. The locale is hardcoded to eitherzh-CNoren-US, so any other language (Russian, German, Japanese, etc.) always renders dates in English format regardless of thelangvalue passed.Root cause
In BlogList, the Intl.DateTimeFormat instance is created with a hardcoded locale:
Fix
Pass
langdirectly toIntl.DateTimeFormat, keeping thezh→zh-CNnormalization and falling back toen-USonly whenlangis not provided:Why this is safe
Intl.DateTimeFormataccepts any valid BCP 47 language tag. If an unsupported tag is passed, it falls back gracefully. Existing behavior forzhandenis unchanged.Fixes #95