Improve simulator limit errors and fix telemetr#475
Conversation
Make all limit-exceeded errors actionable (production context + remediation hints), replace os.Exit(1) in simulation hooks with error returns so CLI telemetry captures all failures, and propagate ExecutionResult_Error as a non-zero exit.
|
| Version | Value |
|---|---|
| Current Fork | `` |
| Latest Upstream | v1.17.3 |
Action Required
- Review abigen changes in upstream (only the
accounts/abi/binddirectory matters) - Compare with our fork in
cmd/generate-bindings/bindings/abigen/ - If relevant changes exist, sync them and update
FORK_METADATA.md - If no abigen changes, just update the version in
FORK_METADATA.mdtov1.17.3
⚠️ Potential Security-Related Commits Detected
- p2p/nat: bump pion/stun to v3 to pull in fixed pion/dtls (#34980) (link)
Files to Review
cmd/generate-bindings/bindings/abigen/bind.gocmd/generate-bindings/bindings/abigen/bindv2.gocmd/generate-bindings/bindings/abigen/template.go
cc @smartcontractkit/bix-framework
|
👋 ejacquier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
| Version | Value |
|---|---|
| Current Fork | `` |
| Latest Upstream | v1.17.3 |
Action Required
- Review abigen changes in upstream (only the
accounts/abi/binddirectory matters) - Compare with our fork in
cmd/generate-bindings/bindings/abigen/ - If relevant changes exist, sync them and update
FORK_METADATA.md - If no abigen changes, just update the version in
FORK_METADATA.mdtov1.17.3
⚠️ Potential Security-Related Commits Detected
- p2p/nat: bump pion/stun to v3 to pull in fixed pion/dtls (#34980) (link)
Files to Review
cmd/generate-bindings/bindings/abigen/bind.gocmd/generate-bindings/bindings/abigen/bindv2.gocmd/generate-bindings/bindings/abigen/template.go
cc @smartcontractkit/bix-framework
Summary
Improves simulator limit error handling to be more actionable and ensures CLI telemetry captures all simulation failures.
Changes
errors.As() without string matching.
ExecutionResult_Error as non-zero exit codes.
Why this matters