Make the async code match the sync code, keep the asyncIterator so in the future we could reintroduce stream as a special version of many.

Boris Smidt · Boris Smidt · commit eecd8a9037b1 · 2026-06-01T11:40:17.000+02:00
Fixes: #101
diff --git a/internal/endtoend/testdata/emit_pydantic_models/db/models.py b/internal/endtoend/testdata/emit_pydantic_models/db/models.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 import pydantic
 from typing import Optional
 
diff --git a/internal/endtoend/testdata/emit_pydantic_models/db/query.py b/internal/endtoend/testdata/emit_pydantic_models/db/query.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 # source: query.sql
 from typing import AsyncIterator, Iterator, Optional
 
@@ -103,8 +103,8 @@ async def get_author(self, *, id: int) -> Optional[models.Author]:
         )
 
     async def list_authors(self) -> AsyncIterator[models.Author]:
-        result = await self._conn.stream(sqlalchemy.text(LIST_AUTHORS))
-        async for row in result:
+        rows = (await self._conn.execute(sqlalchemy.text(LIST_AUTHORS))).all()
+        for row in rows:
             yield models.Author(
                 id=row[0],
                 name=row[1],
diff --git a/internal/endtoend/testdata/emit_str_enum/db/models.py b/internal/endtoend/testdata/emit_str_enum/db/models.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 import dataclasses
 import enum
 from typing import Optional
diff --git a/internal/endtoend/testdata/emit_str_enum/db/query.py b/internal/endtoend/testdata/emit_str_enum/db/query.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 # source: query.sql
 from typing import AsyncIterator, Iterator, Optional
 
@@ -102,8 +102,8 @@ async def get_book(self, *, id: int) -> Optional[models.Book]:
         )
 
     async def list_books(self) -> AsyncIterator[models.Book]:
-        result = await self._conn.stream(sqlalchemy.text(LIST_BOOKS))
-        async for row in result:
+        rows = (await self._conn.execute(sqlalchemy.text(LIST_BOOKS))).all()
+        for row in rows:
             yield models.Book(
                 id=row[0],
                 title=row[1],
diff --git a/internal/endtoend/testdata/exec_result/python/models.py b/internal/endtoend/testdata/exec_result/python/models.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 import dataclasses
 
 
diff --git a/internal/endtoend/testdata/exec_result/python/query.py b/internal/endtoend/testdata/exec_result/python/query.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 # source: query.sql
 import sqlalchemy
 import sqlalchemy.ext.asyncio
diff --git a/internal/endtoend/testdata/exec_rows/python/models.py b/internal/endtoend/testdata/exec_rows/python/models.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 import dataclasses
 
 
diff --git a/internal/endtoend/testdata/exec_rows/python/query.py b/internal/endtoend/testdata/exec_rows/python/query.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 # source: query.sql
 import sqlalchemy
 import sqlalchemy.ext.asyncio
diff --git a/internal/endtoend/testdata/inflection_exclude_table_names/python/models.py b/internal/endtoend/testdata/inflection_exclude_table_names/python/models.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 import dataclasses
 
 
diff --git a/internal/endtoend/testdata/inflection_exclude_table_names/python/query.py b/internal/endtoend/testdata/inflection_exclude_table_names/python/query.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 # source: query.sql
 from typing import Optional
 
diff --git a/internal/endtoend/testdata/query_parameter_limit_two/python/models.py b/internal/endtoend/testdata/query_parameter_limit_two/python/models.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 import dataclasses
 
 
diff --git a/internal/endtoend/testdata/query_parameter_limit_two/python/query.py b/internal/endtoend/testdata/query_parameter_limit_two/python/query.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 # source: query.sql
 import sqlalchemy
 import sqlalchemy.ext.asyncio
diff --git a/internal/endtoend/testdata/query_parameter_limit_undefined/python/models.py b/internal/endtoend/testdata/query_parameter_limit_undefined/python/models.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 import dataclasses
 
 
diff --git a/internal/endtoend/testdata/query_parameter_limit_undefined/python/query.py b/internal/endtoend/testdata/query_parameter_limit_undefined/python/query.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 # source: query.sql
 import sqlalchemy
 import sqlalchemy.ext.asyncio
diff --git a/internal/endtoend/testdata/query_parameter_limit_zero/python/models.py b/internal/endtoend/testdata/query_parameter_limit_zero/python/models.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 import dataclasses
 
 
diff --git a/internal/endtoend/testdata/query_parameter_limit_zero/python/query.py b/internal/endtoend/testdata/query_parameter_limit_zero/python/query.py
@@ -1,6 +1,6 @@
 # Code generated by sqlc. DO NOT EDIT.
 # versions:
-#   sqlc v1.28.0
+#   sqlc v1.31.1
 # source: query.sql
 import dataclasses
 
diff --git a/internal/gen.go b/internal/gen.go
@@ -1020,13 +1020,16 @@ func buildQueryTree(ctx *pyTmplCtx, i *importer, source string) *pyast.Node {
 				)
 				f.Returns = subscriptNode("Optional", q.Ret.Annotation())
 			case ":many":
-				stream := connMethodNode("stream", q.ConstantName, q.ArgDictNode())
 				f.Body = append(f.Body,
-					assignNode("result", poet.Await(stream)),
+					assignNode("rows", poet.Node(
+						&pyast.Call{
+							Func: poet.Attribute(poet.Await(exec), "all"),
+						},
+					)),
 					poet.Node(
-						&pyast.AsyncFor{
+						&pyast.For{
 							Target: poet.Name("row"),
-							Iter:   poet.Name("result"),
+							Iter:   poet.Name("rows"),
 							Body: []*pyast.Node{
 								poet.Expr(
 									poet.Yield(
