From 2851e483d5510c1437095e85c1dc42f4ecff3f8e Mon Sep 17 00:00:00 2001 From: Pierre Gronlier Date: Wed, 15 Apr 2026 16:40:33 +0200 Subject: [PATCH 1/2] fix(core): add container logs to TimeoutError when wait strategy times out --- core/testcontainers/core/container.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core/testcontainers/core/container.py b/core/testcontainers/core/container.py index 680e7ca2..039431c2 100644 --- a/core/testcontainers/core/container.py +++ b/core/testcontainers/core/container.py @@ -217,7 +217,11 @@ def start(self) -> Self: ) if self._wait_strategy is not None: - self._wait_strategy.wait_until_ready(self) + try: + self._wait_strategy.wait_until_ready(self) + except TimeoutError as ex: + ex.add_note(self._container.logs().decode()) + raise ex logger.info("Container started: %s", self._container.short_id) From 441e4732b8c7a8d91fe1590c30ca2fc04310013f Mon Sep 17 00:00:00 2001 From: Dave Ankin Date: Sun, 17 May 2026 21:51:49 -0400 Subject: [PATCH 2/2] fix: add guard for 3.10 --- core/testcontainers/core/container.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/testcontainers/core/container.py b/core/testcontainers/core/container.py index 039431c2..f3507366 100644 --- a/core/testcontainers/core/container.py +++ b/core/testcontainers/core/container.py @@ -220,7 +220,8 @@ def start(self) -> Self: try: self._wait_strategy.wait_until_ready(self) except TimeoutError as ex: - ex.add_note(self._container.logs().decode()) + if hasattr(ex, "add_note"): + ex.add_note(self._container.logs().decode()) raise ex logger.info("Container started: %s", self._container.short_id)