Get item links#16
Open
halloju wants to merge 5 commits into
Open
Conversation
Member
|
This branch has conflicts that must be resolved. |
hrchu
reviewed
Nov 2, 2021
hrchu
reviewed
Nov 2, 2021
hrchu
reviewed
Nov 10, 2021
| def are_files(urls: List) -> bool: | ||
| pass | ||
|
|
||
| def get_links_from_response(response) -> dict: |
| else: | ||
| return parse_link_header(link_header, response.url) | ||
|
|
||
| def parse_link_header(link_header: str, item_url) -> Dict: |
Member
There was a problem hiding this comment.
Do you prefer a Dict instead of Links here?
Member
|
@halloju What server implementation do you test against? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue 7