install: handle piped stdin when target exists#12418
Open
puneetdixit200 wants to merge 2 commits into
Open
Conversation
|
GNU testsuite comparison: |
sylvestre
reviewed
May 23, 2026
|
|
||
| if let Ok(to_meta) = metadata(to) { | ||
| let from_meta = handle.metadata()?; | ||
| if from_meta.dev() == to_meta.dev() && from_meta.ino() == to_meta.ino() { |
Contributor
There was a problem hiding this comment.
please add a comment to explain this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12407.
This updates the copy path to compare the opened source file metadata with the destination instead of canonicalizing the source path. That keeps openable special paths such as
/dev/fd/0working when the destination already exists while preserving same-file detection.Tests:
cargo fmt --checkcargo test --features install --no-default-features test_install::test_install_from_stdin -- --nocapturecargo test --features install --no-default-features test_install:: -- --nocapturecargo test -p uu_installcargo clippy --features install --no-default-features --all-targets -- -D warnings