From 140fbecbdea77e332e1ada6955b5d01e610ead25 Mon Sep 17 00:00:00 2001 From: Brendan Collins Date: Fri, 22 May 2026 10:23:49 -0700 Subject: [PATCH] Drop xfail on test_external_cog_validator now that #2308 is fixed The xfail was added in #2304 as a placeholder so the rio-cogeo CI gate could land green while the overview block ordering bug was being fixed. #2309 landed that writer fix, so the test now passes -- drop the marker and the accompanying comment. --- .../geotiff/tests/test_cog_writer_compliance.py | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/xrspatial/geotiff/tests/test_cog_writer_compliance.py b/xrspatial/geotiff/tests/test_cog_writer_compliance.py index 54afc182..834466ad 100644 --- a/xrspatial/geotiff/tests/test_cog_writer_compliance.py +++ b/xrspatial/geotiff/tests/test_cog_writer_compliance.py @@ -543,22 +543,6 @@ def test_layout_is_cog_shaped(tmp_path): # --------------------------------------------------------------------------- -# The writer currently emits overview tile blocks in the wrong order -# (issue #2308 -- surfaced by this very gate). rio-cogeo reports: -# "The offset of the first block of overview of index 0 should be -# after the one of the overview of index 1" -# The in-process round-trip and the local IFD-before-data layout -# invariant both still pass; only the block ordering across overviews -# trips external validators. xfail (strict=False) so the CI gate is -# wired up and stays green for the rest of the suite. Drop this -# marker once the writer fix lands. -@pytest.mark.xfail( - reason=( - "writer emits overview tile blocks in wrong order; see #2308. " - "Remove xfail when the writer fix lands." - ), - strict=False, -) def test_external_cog_validator(tmp_path): """Run rio-cogeo / GDAL's COG validator if available, else skip cleanly.""" arr = _make_data(np.float32, bands=1, height=256, width=256)