Skip to content

Drop xfail on test_external_cog_validator now that #2308 is fixed #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendancol merged 1 commit into from
May 22, 2026
Merged

Drop xfail on test_external_cog_validator now that #2308 is fixed #2310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions xrspatial/geotiff/tests/test_cog_writer_compliance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,22 +543,6 @@ def test_layout_is_cog_shaped(tmp_path):
# ---------------------------------------------------------------------------


# The writer currently emits overview tile blocks in the wrong order
# (issue #2308 -- surfaced by this very gate). rio-cogeo reports:
# "The offset of the first block of overview of index 0 should be
# after the one of the overview of index 1"
# The in-process round-trip and the local IFD-before-data layout
# invariant both still pass; only the block ordering across overviews
# trips external validators. xfail (strict=False) so the CI gate is
# wired up and stays green for the rest of the suite. Drop this
# marker once the writer fix lands.
@pytest.mark.xfail(
reason=(
"writer emits overview tile blocks in wrong order; see #2308. "
"Remove xfail when the writer fix lands."
),
strict=False,
)
def test_external_cog_validator(tmp_path):
"""Run rio-cogeo / GDAL's COG validator if available, else skip cleanly."""
arr = _make_data(np.float32, bands=1, height=256, width=256)
Expand Down
Loading