Fix missing offsetString in EventContext checkpoint update#48637
Draft
Fix missing offsetString in EventContext checkpoint update#48637
Conversation
Added EventContextTest.updateCheckpointAsyncSetsOffsetString() which verifies that offsetString is populated on the Checkpoint passed to the store. This test fails without the fix (offsetString is null) and passes with it. Fix: added setOffsetString(eventData.getOffsetString()) in EventContext.updateCheckpointAsync(), matching the pattern already used in EventBatchContext. Fixes #46752 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
j7nw4r
force-pushed
the
fix/eventhubs-checkpoint-offset-46752
branch
from
a68fa9c to
1abecdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EventContext.updateCheckpointAsync()only calledsetOffset(Long)(deprecated), butBlobCheckpointStore.updateCheckpoint()readsgetOffsetString()which returnednull— causing the offset to never be stored in checkpoint blob metadata.Added
setOffsetString(eventData.getOffsetString())to match the pattern already used inEventBatchContext.Root Cause
EventContextcreated aCheckpointwith only.setOffset(eventData.getOffset())(deprecated Long setter)BlobCheckpointStore.updateCheckpoint()readscheckpoint.getOffsetString()to write metadataCheckpoint.getOffsetString()has no fallback to the Longoffsetfield, so it returnednullFix
One-line addition of
.setOffsetString(eventData.getOffsetString())inEventContext.updateCheckpointAsync(), consistent withEventBatchContextwhich already calls both setters.Fixes #46752