Merged
Conversation
Instead of obtaining username only from the cert with matching fingerprint, try to obtain it from the whole chain starting from the client cert. Also refactor the ctn code. Fixes CESNET/netopeer2#1797
michalvasko
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to obtain username from any cert in the chain, not just the one whose fingerprint matches. This process always starts from the peer cert. Required building the full chain in MbedTLS (OpenSSL does this by default).
Added a test and a new cert with a SAN field that tests having a cert chain with 2 certs, and if we set CTN's fingerprint to either, we should still use the client's cert with the SAN to resolve the username.
Fixes CESNET/netopeer2#1797