[ENG-11380] Project Overview Page UI Improvements#1014
Open
nsemets wants to merge 2 commits into
Open
Conversation
nsemets
changed the base branch from
feature/pbs-26-9
to
feature/my-projects-improvements
omar-cos
suggested changes
Jun 17, 2026
Comment on lines
+103
to
+105
| readonly isButtonDisabled = computed( | ||
| () => this.isFilesLoading() || this.isStorageLoading() || this.filesTotalCount() === 0 | ||
| ); |
There was a problem hiding this comment.
As per the acceptance criteria of ticket, the Download as Zip option should be visible to logged-in admins only. Currently isButtonDisabled only guards on loading state and file count, so the button renders for all users (contributors, read-only members, etc.). Need to add an admin/write-access check here, e.g. pulling hasWriteAccess or an isAdmin selector and including it in the computed and also wrap the button in an @if in the template so non-admins don't see it at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Screenshot(s)