Support macos walltime without profiling in codspeed-runner#287
Merged
GuillaumeLagrange merged 10 commits intomainfrom Apr 16, 2026
Merged
Conversation
GuillaumeLagrange
force-pushed
the
cod-2459-be-able-to-run-all-integrations-on-macos
branch
2 times, most recently
from
8a9d9bd to
407c55c
Compare
GuillaumeLagrange
force-pushed
the
cod-2459-be-able-to-run-all-integrations-on-macos
branch
4 times, most recently
from
f95953f to
bba9e90
Compare
GuillaumeLagrange
force-pushed
the
cod-2459-be-able-to-run-all-integrations-on-macos
branch
6 times, most recently
from
c07e0c6 to
dc2a772
Compare
GuillaumeLagrange
force-pushed
the
cod-2459-be-able-to-run-all-integrations-on-macos
branch
from
dc2a772 to
8b7c20c
Compare
GuillaumeLagrange
changed the title
not-matthias
requested changes
Apr 14, 2026
Member
not-matthias
left a comment
not-matthias
left a comment
There was a problem hiding this comment.
It's important to consider everything unsupported by default. e.g. if someone runs on a system we haven't considered (e.g. Windows) we shouldn't even try to continue running with best-effort.
Logic could be implemented like this:
- Tool support: Get
Osstruct, check version + distro - Executor: Check each OS, e.g. on Linux: is_debian FullySupported; else RequireManualInstallation; Mac/Windows: Unsupported
- General (check_system): We could refactor this to just iterate over all executors and see if any are supported.
GuillaumeLagrange
force-pushed
the
cod-2459-be-able-to-run-all-integrations-on-macos
branch
from
bb820ae to
be6956c
Compare
Contributor
Author
|
@not-matthias I've done the following
|
GuillaumeLagrange
force-pushed
the
cod-2459-be-able-to-run-all-integrations-on-macos
branch
2 times, most recently
from
abefba1 to
2fdce4e
Compare
not-matthias
approved these changes
Apr 16, 2026
Member
not-matthias
left a comment
not-matthias
left a comment
There was a problem hiding this comment.
LGTM, just two minor style comments
GuillaumeLagrange
force-pushed
the
cod-2459-be-able-to-run-all-integrations-on-macos
branch
3 times, most recently
from
1cb2811 to
3c21514
Compare
On macos a symlink breaks the existing test creating an infinite loop where `instropected_go` detects itself as the real `go` executable. Fixed by changing the behavior to what instrospected_node does.
Fixes compilation warnings in exec-harness's build script.
…ecutor support gates Only supported Oses can be represented, the runner will bail if it detects a non supported os. Then, each executor can define its support level for the current system depending on the Os and, for example, the linux distribution/version.
These tests panic on macOS, and for now are not relevant since we do not support profiling on macOS. When we do support it, we should have os-specific tests
GuillaumeLagrange
force-pushed
the
cod-2459-be-able-to-run-all-integrations-on-macos
branch
from
3c21514 to
25ee001
Compare
GuillaumeLagrange
force-pushed
the
cod-2459-be-able-to-run-all-integrations-on-macos
branch
from
26b0434 to
8e74cca
Compare
GuillaumeLagrange
deleted the
cod-2459-be-able-to-run-all-integrations-on-macos
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.