Configure CORS Allowed Origins via ConfigMaps#500
Open
TineoC wants to merge 3 commits intoCodeForPhilly:developfrom
Open
Configure CORS Allowed Origins via ConfigMaps#500TineoC wants to merge 3 commits intoCodeForPhilly:developfrom
TineoC wants to merge 3 commits intoCodeForPhilly:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #497
This PR makes CORS allowed origins configurable via environment variables and Kubernetes ConfigMaps.
Changes:
server/balancer_backend/settings.pyto readCORS_ALLOWED_ORIGINSfrom environment, defaulting tolocalhost:3000.envFromfrom a ConfigMap namedbalancer-config.configMapGeneratorto the basekustomization.yaml.sandboxandproductionoverlays with their respectiveCORS_ALLOWED_ORIGINSconfigured in aconfigmap.yamlpatch.Deployment note: Ensure that the
balancer-configConfigMap is created or generated in the target namespace.