Skip to content

Fix iframe strict mode violation in E2E tests #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mraible wants to merge 3 commits into from
Closed

Fix iframe strict mode violation in E2E tests #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7453c76
Fix CVEs: add npm overrides for picomatch, yaml, brace-expansion, lodash
mraible Apr 6, 2026
d102f8e
Revert lodash override to 4.17.23 (4.18.1 fix version not yet available)
mraible Apr 6, 2026
26b5586
Fix iframe strict mode violation when 2 iframes exist
mraible Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/src/pages/HelloExtensionPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class HelloExtensionPage extends SocketNavigationPage {
}

// Verify iframe loads
await expect(this.page.locator('iframe')).toBeVisible({ timeout: 15000 });
await expect(this.page.locator('iframe').first()).toBeVisible({ timeout: 15000 });
this.logger.info('Extension iframe loaded');

// Verify iframe content
Expand Down
60 changes: 33 additions & 27 deletions ui/extensions/hello/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion ui/extensions/hello/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@
"lodash": "4.17.23",
"svgo": "2.8.1",
"minimatch@3": "3.1.4",
"minimatch@9": "9.0.9"
"minimatch@9": "9.0.9",
"picomatch@2": "2.3.2",
"picomatch@4": "4.0.4",
"yaml@1": "1.10.3",
"brace-expansion@2": "2.0.3"
}
}
3 changes: 3 additions & 0 deletions ui/extensions/hello/src/dist/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3857,6 +3857,9 @@ class Navigation {
},
});
}
/**
* @deprecated Use navigateTo directly
*/
async onClick(event, defaultTarget = '_self', defaultType = 'falcon') {
if (!(event instanceof Event)) {
throw Error('"event" property should be subclass of Event');
Expand Down
Loading