Draft
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 64 metrics, 6 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~8aa7457aea, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063652
Total [baseline] (8.87 s) : 0, 8870447
Agent [candidate] (1.071 s) : 0, 1071101
Total [candidate] (8.891 s) : 0, 8891031
section iast
Agent [baseline] (1.235 s) : 0, 1234743
Total [baseline] (9.611 s) : 0, 9611478
Agent [candidate] (1.233 s) : 0, 1232974
Total [candidate] (9.616 s) : 0, 9615652
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~8aa7457aea, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (632.75 ms) : 0, 632750
BytebuddyAgent [candidate] (635.511 ms) : 0, 635511
AgentMeter [baseline] (29.485 ms) : 0, 29485
AgentMeter [candidate] (29.725 ms) : 0, 29725
GlobalTracer [baseline] (258.668 ms) : 0, 258668
GlobalTracer [candidate] (261.313 ms) : 0, 261313
AppSec [baseline] (32.062 ms) : 0, 32062
AppSec [candidate] (32.462 ms) : 0, 32462
Debugger [baseline] (60.231 ms) : 0, 60231
Debugger [candidate] (60.781 ms) : 0, 60781
Remote Config [baseline] (593.572 µs) : 0, 594
Remote Config [candidate] (600.235 µs) : 0, 600
Telemetry [baseline] (8.108 ms) : 0, 8108
Telemetry [candidate] (8.206 ms) : 0, 8206
Flare Poller [baseline] (4.261 ms) : 0, 4261
Flare Poller [candidate] (5.047 ms) : 0, 5047
section iast
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (800.717 ms) : 0, 800717
BytebuddyAgent [candidate] (800.291 ms) : 0, 800291
AgentMeter [baseline] (11.476 ms) : 0, 11476
AgentMeter [candidate] (11.469 ms) : 0, 11469
GlobalTracer [baseline] (249.186 ms) : 0, 249186
GlobalTracer [candidate] (248.492 ms) : 0, 248492
AppSec [baseline] (27.653 ms) : 0, 27653
AppSec [candidate] (26.689 ms) : 0, 26689
Debugger [baseline] (68.867 ms) : 0, 68867
Debugger [candidate] (69.239 ms) : 0, 69239
Remote Config [baseline] (549.379 µs) : 0, 549
Remote Config [candidate] (532.24 µs) : 0, 532
Telemetry [baseline] (9.78 ms) : 0, 9780
Telemetry [candidate] (9.859 ms) : 0, 9859
Flare Poller [baseline] (3.557 ms) : 0, 3557
Flare Poller [candidate] (3.526 ms) : 0, 3526
IAST [baseline] (25.428 ms) : 0, 25428
IAST [candidate] (25.375 ms) : 0, 25375
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~8aa7457aea, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062325
Total [baseline] (11.114 s) : 0, 11113828
Agent [candidate] (1.063 s) : 0, 1062799
Total [candidate] (11.102 s) : 0, 11102034
section appsec
Agent [baseline] (1.255 s) : 0, 1254619
Total [baseline] (11.186 s) : 0, 11186020
Agent [candidate] (1.252 s) : 0, 1252181
Total [candidate] (11.231 s) : 0, 11230554
section iast
Agent [baseline] (1.234 s) : 0, 1233786
Total [baseline] (11.376 s) : 0, 11375991
Agent [candidate] (1.239 s) : 0, 1238553
Total [candidate] (11.315 s) : 0, 11315009
section profiling
Agent [baseline] (1.188 s) : 0, 1188310
Total [baseline] (11.142 s) : 0, 11142337
Agent [candidate] (1.188 s) : 0, 1188278
Total [candidate] (11.032 s) : 0, 11031807
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~8aa7457aea, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (631.539 ms) : 0, 631539
BytebuddyAgent [candidate] (631.743 ms) : 0, 631743
AgentMeter [baseline] (29.497 ms) : 0, 29497
AgentMeter [candidate] (29.569 ms) : 0, 29569
GlobalTracer [baseline] (258.432 ms) : 0, 258432
GlobalTracer [candidate] (258.641 ms) : 0, 258641
AppSec [baseline] (31.908 ms) : 0, 31908
AppSec [candidate] (31.959 ms) : 0, 31959
Debugger [baseline] (60.682 ms) : 0, 60682
Debugger [candidate] (60.546 ms) : 0, 60546
Remote Config [baseline] (590.871 µs) : 0, 591
Remote Config [candidate] (578.959 µs) : 0, 579
Telemetry [baseline] (8.088 ms) : 0, 8088
Telemetry [candidate] (8.05 ms) : 0, 8050
Flare Poller [baseline] (4.178 ms) : 0, 4178
Flare Poller [candidate] (4.289 ms) : 0, 4289
section appsec
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (662.918 ms) : 0, 662918
BytebuddyAgent [candidate] (661.237 ms) : 0, 661237
AgentMeter [baseline] (12.27 ms) : 0, 12270
AgentMeter [candidate] (12.183 ms) : 0, 12183
GlobalTracer [baseline] (259.489 ms) : 0, 259489
GlobalTracer [candidate] (259.615 ms) : 0, 259615
AppSec [baseline] (178.519 ms) : 0, 178519
AppSec [candidate] (177.971 ms) : 0, 177971
Debugger [baseline] (66.757 ms) : 0, 66757
Debugger [candidate] (66.628 ms) : 0, 66628
Remote Config [baseline] (645.952 µs) : 0, 646
Remote Config [candidate] (626.435 µs) : 0, 626
Telemetry [baseline] (8.433 ms) : 0, 8433
Telemetry [candidate] (8.478 ms) : 0, 8478
Flare Poller [baseline] (3.631 ms) : 0, 3631
Flare Poller [candidate] (3.641 ms) : 0, 3641
IAST [baseline] (24.306 ms) : 0, 24306
IAST [candidate] (24.254 ms) : 0, 24254
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (800.315 ms) : 0, 800315
BytebuddyAgent [candidate] (802.097 ms) : 0, 802097
AgentMeter [baseline] (11.47 ms) : 0, 11470
AgentMeter [candidate] (11.546 ms) : 0, 11546
GlobalTracer [baseline] (248.742 ms) : 0, 248742
GlobalTracer [candidate] (250.023 ms) : 0, 250023
AppSec [baseline] (26.598 ms) : 0, 26598
AppSec [candidate] (27.075 ms) : 0, 27075
Debugger [baseline] (70.704 ms) : 0, 70704
Debugger [candidate] (71.357 ms) : 0, 71357
Remote Config [baseline] (539.209 µs) : 0, 539
Remote Config [candidate] (544.756 µs) : 0, 545
Telemetry [baseline] (9.169 ms) : 0, 9169
Telemetry [candidate] (9.287 ms) : 0, 9287
Flare Poller [baseline] (3.36 ms) : 0, 3360
Flare Poller [candidate] (3.53 ms) : 0, 3530
IAST [baseline] (25.441 ms) : 0, 25441
IAST [candidate] (25.584 ms) : 0, 25584
section profiling
ProfilingAgent [baseline] (94.432 ms) : 0, 94432
ProfilingAgent [candidate] (94.707 ms) : 0, 94707
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (686.206 ms) : 0, 686206
BytebuddyAgent [candidate] (686.168 ms) : 0, 686168
AgentMeter [baseline] (8.986 ms) : 0, 8986
AgentMeter [candidate] (9.02 ms) : 0, 9020
GlobalTracer [baseline] (215.922 ms) : 0, 215922
GlobalTracer [candidate] (215.801 ms) : 0, 215801
AppSec [baseline] (32.178 ms) : 0, 32178
AppSec [candidate] (32.268 ms) : 0, 32268
Debugger [baseline] (65.573 ms) : 0, 65573
Debugger [candidate] (66.024 ms) : 0, 66024
Remote Config [baseline] (583.834 µs) : 0, 584
Remote Config [candidate] (567.385 µs) : 0, 567
Telemetry [baseline] (8.555 ms) : 0, 8555
Telemetry [candidate] (7.777 ms) : 0, 7777
Flare Poller [baseline] (3.509 ms) : 0, 3509
Flare Poller [candidate] (3.482 ms) : 0, 3482
Profiling [baseline] (94.987 ms) : 0, 94987
Profiling [candidate] (95.26 ms) : 0, 95260
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~8aa7457aea, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section baseline
no_agent (1.227 ms) : 1215, 1238
. : milestone, 1227,
iast (3.187 ms) : 3146, 3228
. : milestone, 3187,
iast_FULL (6.249 ms) : 6184, 6314
. : milestone, 6249,
iast_GLOBAL (3.723 ms) : 3670, 3776
. : milestone, 3723,
profiling (2.213 ms) : 2192, 2233
. : milestone, 2213,
tracing (1.834 ms) : 1819, 1849
. : milestone, 1834,
section candidate
no_agent (1.23 ms) : 1218, 1242
. : milestone, 1230,
iast (3.285 ms) : 3242, 3328
. : milestone, 3285,
iast_FULL (6.142 ms) : 6079, 6204
. : milestone, 6142,
iast_GLOBAL (3.568 ms) : 3510, 3627
. : milestone, 3568,
profiling (2.066 ms) : 2048, 2084
. : milestone, 2066,
tracing (1.837 ms) : 1822, 1852
. : milestone, 1837,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~8aa7457aea, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section baseline
no_agent (18.331 ms) : 18145, 18516
. : milestone, 18331,
appsec (19.899 ms) : 19689, 20110
. : milestone, 19899,
code_origins (18.756 ms) : 18570, 18941
. : milestone, 18756,
iast (19.105 ms) : 18913, 19298
. : milestone, 19105,
profiling (20.055 ms) : 19849, 20261
. : milestone, 20055,
tracing (17.731 ms) : 17557, 17904
. : milestone, 17731,
section candidate
no_agent (19.632 ms) : 19431, 19832
. : milestone, 19632,
appsec (20.036 ms) : 19831, 20241
. : milestone, 20036,
code_origins (17.665 ms) : 17490, 17841
. : milestone, 17665,
iast (18.293 ms) : 18112, 18474
. : milestone, 18293,
profiling (19.779 ms) : 19581, 19977
. : milestone, 19779,
tracing (18.061 ms) : 17883, 18240
. : milestone, 18061,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~8aa7457aea, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section baseline
no_agent (15.009 s) : 15009000, 15009000
. : milestone, 15009000,
appsec (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
iast (18.012 s) : 18012000, 18012000
. : milestone, 18012000,
iast_GLOBAL (18.242 s) : 18242000, 18242000
. : milestone, 18242000,
profiling (15.412 s) : 15412000, 15412000
. : milestone, 15412000,
tracing (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
section candidate
no_agent (15.552 s) : 15552000, 15552000
. : milestone, 15552000,
appsec (14.893 s) : 14893000, 14893000
. : milestone, 14893000,
iast (18.437 s) : 18437000, 18437000
. : milestone, 18437000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
. : milestone, 18003000,
profiling (14.774 s) : 14774000, 14774000
. : milestone, 14774000,
tracing (15.19 s) : 15190000, 15190000
. : milestone, 15190000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~8aa7457aea, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section baseline
no_agent (1.493 ms) : 1481, 1505
. : milestone, 1493,
appsec (3.775 ms) : 3557, 3993
. : milestone, 3775,
iast (2.284 ms) : 2215, 2353
. : milestone, 2284,
iast_GLOBAL (2.337 ms) : 2267, 2407
. : milestone, 2337,
profiling (2.126 ms) : 2069, 2183
. : milestone, 2126,
tracing (2.092 ms) : 2038, 2146
. : milestone, 2092,
section candidate
no_agent (1.492 ms) : 1481, 1504
. : milestone, 1492,
appsec (3.767 ms) : 3550, 3985
. : milestone, 3767,
iast (2.288 ms) : 2218, 2357
. : milestone, 2288,
iast_GLOBAL (2.331 ms) : 2261, 2401
. : milestone, 2331,
profiling (2.137 ms) : 2079, 2194
. : milestone, 2137,
tracing (2.091 ms) : 2037, 2145
. : milestone, 2091,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add support for additional metric tags as primary tags
Motivation
Additional Notes
The spec is changing, so this is not accurate. "The config will be deprecated from the agent and will only be configured at the tracer level. For java this would include system-properties / env var / config file / in code API. An example for the last being span.SetMeasuredTag()"
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.