Skip to content

Set Java-specific injection package size ratchet#11020

Open
lloeki wants to merge 1 commit intomasterfrom
lloeki/injection-size-ratchet
Open

Set Java-specific injection package size ratchet#11020
lloeki wants to merge 1 commit intomasterfrom
lloeki/injection-size-ratchet

Conversation

@lloeki
Copy link
Copy Markdown
Member

@lloeki lloeki commented Apr 1, 2026

What Does This Do

Introduce language-specific thresholds for the injection image size ratchet through one pipeline overrides

Motivation

Due to a change PHP-side libdatadog was bumped to v29. This version bump caused PHP images to blow past their previous limit.

Simultaneously, changes to the datadog-package binary were picked up. Notably the github.com/klauspost/compress/zstd dependency was bumped from 1.17.4 to 1.18.1. This bump included in 1.17.5 a default value change for the compression context size, downscaled from 32MB to 8MB (fixing compatibility with browsers like Chrome), causing drastic changes in compression results.

Unbeknownst to the second change, PHP therefore updated the global limits, attributing the size change to the libdatadog bump (which was true, but not for the whole of it):

This allowed a change to slip through to other languages, where the new datadog-package binary caused regressions in package size without change to the inputs. Due to the wildly differing sizes of packages across languages the regression is silent, rendering the size threshold ratchet moot.

To combat such silently creeping regressions, this PR introduces language-specific thresholds for the ratchet.

Additional Notes

datadog-package was fixed in https://github.com/DataDog/datadog-packages/pull/64 which may take some time to trickle down.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@lloeki lloeki added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Apr 1, 2026
@lloeki lloeki requested a review from a team as a code owner April 1, 2026 13:04
@lloeki lloeki requested review from colin-higgins and removed request for a team April 1, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant