Update Environment Variable Normalization to not add DD prefix for OTel Configs#11044
Update Environment Variable Normalization to not add DD prefix for OTel Configs#11044
Conversation
| @Nonnull | ||
| public static String propertyNameToEnvironmentVariableName(final String setting) { | ||
| // OTel configurations should not be normalized with DD_ | ||
| if (setting.startsWith("otel.") || setting.startsWith("OTEL_")) { |
There was a problem hiding this comment.
💭 thought: The settings did not check for the dd. presence in the first place so I wonder if this kind of check should not be better upstream. I will have a proper review later Today hopefully (or early next week)
There was a problem hiding this comment.
I initially did it here to avoid adding extra imports to ConfigSetting, but it would make more sense to leave it there since that is only used for telemetry (the reason for this change)
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~501e36ede9, baseline=1.61.0-SNAPSHOT~e16815c31c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062462
Total [baseline] (8.841 s) : 0, 8840947
Agent [candidate] (1.058 s) : 0, 1058294
Total [candidate] (8.858 s) : 0, 8858432
section iast
Agent [baseline] (1.227 s) : 0, 1227270
Total [baseline] (9.545 s) : 0, 9545223
Agent [candidate] (1.223 s) : 0, 1223458
Total [candidate] (9.585 s) : 0, 9585237
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~501e36ede9, baseline=1.61.0-SNAPSHOT~e16815c31c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (637.481 ms) : 0, 637481
BytebuddyAgent [candidate] (634.49 ms) : 0, 634490
AgentMeter [baseline] (29.647 ms) : 0, 29647
AgentMeter [candidate] (29.436 ms) : 0, 29436
GlobalTracer [baseline] (249.85 ms) : 0, 249850
GlobalTracer [candidate] (249.261 ms) : 0, 249261
AppSec [baseline] (32.262 ms) : 0, 32262
AppSec [candidate] (32.036 ms) : 0, 32036
Debugger [baseline] (59.587 ms) : 0, 59587
Debugger [candidate] (59.557 ms) : 0, 59557
Remote Config [baseline] (612.757 µs) : 0, 613
Remote Config [candidate] (615.823 µs) : 0, 616
Telemetry [baseline] (8.128 ms) : 0, 8128
Telemetry [candidate] (8.048 ms) : 0, 8048
Flare Poller [baseline] (7.36 ms) : 0, 7360
Flare Poller [candidate] (7.393 ms) : 0, 7393
section iast
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (803.57 ms) : 0, 803570
BytebuddyAgent [candidate] (801.153 ms) : 0, 801153
AgentMeter [baseline] (11.429 ms) : 0, 11429
AgentMeter [candidate] (11.344 ms) : 0, 11344
GlobalTracer [baseline] (239.543 ms) : 0, 239543
GlobalTracer [candidate] (239.11 ms) : 0, 239110
AppSec [baseline] (30.272 ms) : 0, 30272
AppSec [candidate] (29.466 ms) : 0, 29466
Debugger [baseline] (59.565 ms) : 0, 59565
Debugger [candidate] (59.137 ms) : 0, 59137
Remote Config [baseline] (521.006 µs) : 0, 521
Remote Config [candidate] (543.441 µs) : 0, 543
Telemetry [baseline] (14.633 ms) : 0, 14633
Telemetry [candidate] (14.132 ms) : 0, 14132
Flare Poller [baseline] (3.809 ms) : 0, 3809
Flare Poller [candidate] (4.432 ms) : 0, 4432
IAST [baseline] (25.954 ms) : 0, 25954
IAST [candidate] (26.631 ms) : 0, 26631
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~501e36ede9, baseline=1.61.0-SNAPSHOT~e16815c31c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066462
Total [baseline] (10.991 s) : 0, 10990869
Agent [candidate] (1.061 s) : 0, 1060772
Total [candidate] (11.047 s) : 0, 11046576
section appsec
Agent [baseline] (1.253 s) : 0, 1253052
Total [baseline] (11.116 s) : 0, 11115772
Agent [candidate] (1.249 s) : 0, 1249462
Total [candidate] (11.142 s) : 0, 11141988
section iast
Agent [baseline] (1.227 s) : 0, 1226930
Total [baseline] (11.222 s) : 0, 11222314
Agent [candidate] (1.224 s) : 0, 1224425
Total [candidate] (11.309 s) : 0, 11309066
section profiling
Agent [baseline] (1.193 s) : 0, 1193233
Total [baseline] (11.121 s) : 0, 11121217
Agent [candidate] (1.19 s) : 0, 1190222
Total [candidate] (11.005 s) : 0, 11005199
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~501e36ede9, baseline=1.61.0-SNAPSHOT~e16815c31c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (638.268 ms) : 0, 638268
BytebuddyAgent [candidate] (633.619 ms) : 0, 633619
AgentMeter [baseline] (29.678 ms) : 0, 29678
AgentMeter [candidate] (29.418 ms) : 0, 29418
GlobalTracer [baseline] (251.331 ms) : 0, 251331
GlobalTracer [candidate] (249.185 ms) : 0, 249185
AppSec [baseline] (31.93 ms) : 0, 31930
AppSec [candidate] (31.991 ms) : 0, 31991
Debugger [baseline] (59.934 ms) : 0, 59934
Debugger [candidate] (60.189 ms) : 0, 60189
Remote Config [baseline] (598.572 µs) : 0, 599
Remote Config [candidate] (606.584 µs) : 0, 607
Telemetry [baseline] (8.109 ms) : 0, 8109
Telemetry [candidate] (8.062 ms) : 0, 8062
Flare Poller [baseline] (9.139 ms) : 0, 9139
Flare Poller [candidate] (10.485 ms) : 0, 10485
section appsec
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (663.999 ms) : 0, 663999
BytebuddyAgent [candidate] (662.972 ms) : 0, 662972
AgentMeter [baseline] (12.073 ms) : 0, 12073
AgentMeter [candidate] (12.119 ms) : 0, 12119
GlobalTracer [baseline] (250.574 ms) : 0, 250574
GlobalTracer [candidate] (249.195 ms) : 0, 249195
AppSec [baseline] (184.759 ms) : 0, 184759
AppSec [candidate] (183.974 ms) : 0, 183974
Debugger [baseline] (66.458 ms) : 0, 66458
Debugger [candidate] (66.278 ms) : 0, 66278
Remote Config [baseline] (609.612 µs) : 0, 610
Remote Config [candidate] (619.029 µs) : 0, 619
Telemetry [baseline] (8.744 ms) : 0, 8744
Telemetry [candidate] (8.601 ms) : 0, 8601
Flare Poller [baseline] (3.579 ms) : 0, 3579
Flare Poller [candidate] (3.563 ms) : 0, 3563
IAST [baseline] (24.664 ms) : 0, 24664
IAST [candidate] (24.609 ms) : 0, 24609
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (802.912 ms) : 0, 802912
BytebuddyAgent [candidate] (800.841 ms) : 0, 800841
AgentMeter [baseline] (11.399 ms) : 0, 11399
AgentMeter [candidate] (11.398 ms) : 0, 11398
GlobalTracer [baseline] (239.328 ms) : 0, 239328
GlobalTracer [candidate] (238.888 ms) : 0, 238888
AppSec [baseline] (31.097 ms) : 0, 31097
AppSec [candidate] (28.658 ms) : 0, 28658
Debugger [baseline] (59.382 ms) : 0, 59382
Debugger [candidate] (61.968 ms) : 0, 61968
Remote Config [baseline] (531.454 µs) : 0, 531
Remote Config [candidate] (510.008 µs) : 0, 510
Telemetry [baseline] (14.495 ms) : 0, 14495
Telemetry [candidate] (14.452 ms) : 0, 14452
Flare Poller [baseline] (4.243 ms) : 0, 4243
Flare Poller [candidate] (4.428 ms) : 0, 4428
IAST [baseline] (25.92 ms) : 0, 25920
IAST [candidate] (25.875 ms) : 0, 25875
section profiling
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (697.269 ms) : 0, 697269
BytebuddyAgent [candidate] (696.023 ms) : 0, 696023
AgentMeter [baseline] (9.209 ms) : 0, 9209
AgentMeter [candidate] (9.161 ms) : 0, 9161
GlobalTracer [baseline] (208.601 ms) : 0, 208601
GlobalTracer [candidate] (207.975 ms) : 0, 207975
AppSec [baseline] (32.778 ms) : 0, 32778
AppSec [candidate] (32.857 ms) : 0, 32857
Debugger [baseline] (65.694 ms) : 0, 65694
Debugger [candidate] (65.937 ms) : 0, 65937
Remote Config [baseline] (572.917 µs) : 0, 573
Remote Config [candidate] (562.227 µs) : 0, 562
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (7.807 ms) : 0, 7807
Flare Poller [baseline] (3.612 ms) : 0, 3612
Flare Poller [candidate] (3.587 ms) : 0, 3587
ProfilingAgent [baseline] (93.788 ms) : 0, 93788
ProfilingAgent [candidate] (93.553 ms) : 0, 93553
Profiling [baseline] (94.36 ms) : 0, 94360
Profiling [candidate] (94.126 ms) : 0, 94126
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~501e36ede9, baseline=1.61.0-SNAPSHOT~e16815c31c
dateFormat X
axisFormat %s
section baseline
no_agent (1.218 ms) : 1207, 1230
. : milestone, 1218,
iast (3.332 ms) : 3284, 3380
. : milestone, 3332,
iast_FULL (5.93 ms) : 5869, 5990
. : milestone, 5930,
iast_GLOBAL (3.794 ms) : 3724, 3864
. : milestone, 3794,
profiling (2.218 ms) : 2197, 2239
. : milestone, 2218,
tracing (1.879 ms) : 1863, 1895
. : milestone, 1879,
section candidate
no_agent (1.219 ms) : 1208, 1231
. : milestone, 1219,
iast (3.382 ms) : 3335, 3428
. : milestone, 3382,
iast_FULL (6.0 ms) : 5938, 6061
. : milestone, 6000,
iast_GLOBAL (3.563 ms) : 3515, 3611
. : milestone, 3563,
profiling (2.222 ms) : 2200, 2243
. : milestone, 2222,
tracing (1.84 ms) : 1825, 1854
. : milestone, 1840,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~501e36ede9, baseline=1.61.0-SNAPSHOT~e16815c31c
dateFormat X
axisFormat %s
section baseline
no_agent (18.992 ms) : 18800, 19183
. : milestone, 18992,
appsec (18.674 ms) : 18484, 18863
. : milestone, 18674,
code_origins (17.861 ms) : 17684, 18038
. : milestone, 17861,
iast (17.976 ms) : 17800, 18152
. : milestone, 17976,
profiling (19.09 ms) : 18896, 19284
. : milestone, 19090,
tracing (18.022 ms) : 17845, 18199
. : milestone, 18022,
section candidate
no_agent (18.06 ms) : 17871, 18249
. : milestone, 18060,
appsec (18.886 ms) : 18694, 19079
. : milestone, 18886,
code_origins (17.946 ms) : 17771, 18120
. : milestone, 17946,
iast (17.585 ms) : 17412, 17758
. : milestone, 17585,
profiling (18.797 ms) : 18605, 18988
. : milestone, 18797,
tracing (17.798 ms) : 17621, 17975
. : milestone, 17798,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~501e36ede9, baseline=1.61.0-SNAPSHOT~e16815c31c
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1495
. : milestone, 1483,
appsec (3.826 ms) : 3603, 4049
. : milestone, 3826,
iast (2.261 ms) : 2192, 2331
. : milestone, 2261,
iast_GLOBAL (2.32 ms) : 2250, 2389
. : milestone, 2320,
profiling (2.094 ms) : 2040, 2149
. : milestone, 2094,
tracing (2.075 ms) : 2022, 2129
. : milestone, 2075,
section candidate
no_agent (1.487 ms) : 1475, 1499
. : milestone, 1487,
appsec (3.82 ms) : 3598, 4042
. : milestone, 3820,
iast (2.27 ms) : 2201, 2339
. : milestone, 2270,
iast_GLOBAL (2.32 ms) : 2250, 2389
. : milestone, 2320,
profiling (2.125 ms) : 2069, 2182
. : milestone, 2125,
tracing (2.07 ms) : 2017, 2124
. : milestone, 2070,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~501e36ede9, baseline=1.61.0-SNAPSHOT~e16815c31c
dateFormat X
axisFormat %s
section baseline
no_agent (15.403 s) : 15403000, 15403000
. : milestone, 15403000,
appsec (14.771 s) : 14771000, 14771000
. : milestone, 14771000,
iast (18.107 s) : 18107000, 18107000
. : milestone, 18107000,
iast_GLOBAL (17.281 s) : 17281000, 17281000
. : milestone, 17281000,
profiling (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
tracing (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
section candidate
no_agent (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
appsec (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
iast (18.569 s) : 18569000, 18569000
. : milestone, 18569000,
iast_GLOBAL (18.43 s) : 18430000, 18430000
. : milestone, 18430000,
profiling (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
tracing (14.854 s) : 14854000, 14854000
. : milestone, 14854000,
|
What Does This Do
This PR updates the existing environment variable normalization to only add
DD_prefix for nonOTEL_orotel.configurations. This will impact config telemetry as OTel configs will no longer be sent to telemetry asDD_OTEL_, and instead only haveOTEL_.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.