FF crashtracking extended info, and improve runtime args filtering#11048
Open
FF crashtracking extended info, and improve runtime args filtering#11048
Conversation
Precisely this matches any `key` rather that composite terms like `app-key`, which covers more ground.
JDK JEP-8372760 (JFR In-Process Data Redaction)
267db0a to
614c1fe
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~a65abcd552, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055932
Total [baseline] (11.1 s) : 0, 11099734
Agent [candidate] (1.059 s) : 0, 1059100
Total [candidate] (11.007 s) : 0, 11007402
section appsec
Agent [baseline] (1.252 s) : 0, 1252474
Total [baseline] (11.165 s) : 0, 11164768
Agent [candidate] (1.259 s) : 0, 1258802
Total [candidate] (11.154 s) : 0, 11154454
section iast
Agent [baseline] (1.23 s) : 0, 1229687
Total [baseline] (11.302 s) : 0, 11301947
Agent [candidate] (1.23 s) : 0, 1229546
Total [candidate] (11.242 s) : 0, 11242073
section profiling
Agent [baseline] (1.186 s) : 0, 1186133
Total [baseline] (11.094 s) : 0, 11093829
Agent [candidate] (1.187 s) : 0, 1187172
Total [candidate] (11.081 s) : 0, 11081198
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~a65abcd552, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (632.341 ms) : 0, 632341
BytebuddyAgent [candidate] (632.346 ms) : 0, 632346
AgentMeter [baseline] (29.522 ms) : 0, 29522
AgentMeter [candidate] (29.53 ms) : 0, 29530
GlobalTracer [baseline] (249.326 ms) : 0, 249326
GlobalTracer [candidate] (249.105 ms) : 0, 249105
AppSec [baseline] (31.915 ms) : 0, 31915
AppSec [candidate] (31.971 ms) : 0, 31971
Debugger [baseline] (60.217 ms) : 0, 60217
Debugger [candidate] (59.949 ms) : 0, 59949
Remote Config [baseline] (602.715 µs) : 0, 603
Remote Config [candidate] (603.627 µs) : 0, 604
Telemetry [baseline] (8.051 ms) : 0, 8051
Telemetry [candidate] (8.149 ms) : 0, 8149
Flare Poller [baseline] (6.597 ms) : 0, 6597
Flare Poller [candidate] (9.987 ms) : 0, 9987
section appsec
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (664.674 ms) : 0, 664674
BytebuddyAgent [candidate] (667.463 ms) : 0, 667463
AgentMeter [baseline] (12.102 ms) : 0, 12102
AgentMeter [candidate] (12.203 ms) : 0, 12203
GlobalTracer [baseline] (249.694 ms) : 0, 249694
GlobalTracer [candidate] (250.841 ms) : 0, 250841
AppSec [baseline] (184.363 ms) : 0, 184363
AppSec [candidate] (185.552 ms) : 0, 185552
Debugger [baseline] (66.429 ms) : 0, 66429
Debugger [candidate] (67.171 ms) : 0, 67171
Remote Config [baseline] (615.205 µs) : 0, 615
Remote Config [candidate] (620.164 µs) : 0, 620
Telemetry [baseline] (8.717 ms) : 0, 8717
Telemetry [candidate] (8.68 ms) : 0, 8680
Flare Poller [baseline] (3.545 ms) : 0, 3545
Flare Poller [candidate] (3.659 ms) : 0, 3659
IAST [baseline] (24.592 ms) : 0, 24592
IAST [candidate] (24.79 ms) : 0, 24790
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (804.033 ms) : 0, 804033
BytebuddyAgent [candidate] (803.849 ms) : 0, 803849
AgentMeter [baseline] (11.476 ms) : 0, 11476
AgentMeter [candidate] (11.493 ms) : 0, 11493
GlobalTracer [baseline] (240.779 ms) : 0, 240779
GlobalTracer [candidate] (240.833 ms) : 0, 240833
AppSec [baseline] (32.002 ms) : 0, 32002
AppSec [candidate] (32.769 ms) : 0, 32769
Debugger [baseline] (58.611 ms) : 0, 58611
Debugger [candidate] (57.622 ms) : 0, 57622
Remote Config [baseline] (527.119 µs) : 0, 527
Remote Config [candidate] (524.179 µs) : 0, 524
Telemetry [baseline] (14.198 ms) : 0, 14198
Telemetry [candidate] (14.614 ms) : 0, 14614
Flare Poller [baseline] (4.119 ms) : 0, 4119
Flare Poller [candidate] (4.255 ms) : 0, 4255
IAST [baseline] (26.04 ms) : 0, 26040
IAST [candidate] (26.076 ms) : 0, 26076
section profiling
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (692.51 ms) : 0, 692510
BytebuddyAgent [candidate] (693.421 ms) : 0, 693421
AgentMeter [baseline] (9.159 ms) : 0, 9159
AgentMeter [candidate] (9.201 ms) : 0, 9201
GlobalTracer [baseline] (207.381 ms) : 0, 207381
GlobalTracer [candidate] (207.568 ms) : 0, 207568
AppSec [baseline] (32.502 ms) : 0, 32502
AppSec [candidate] (32.53 ms) : 0, 32530
Debugger [baseline] (65.954 ms) : 0, 65954
Debugger [candidate] (65.87 ms) : 0, 65870
Remote Config [baseline] (568.968 µs) : 0, 569
Remote Config [candidate] (571.77 µs) : 0, 572
Telemetry [baseline] (7.86 ms) : 0, 7860
Telemetry [candidate] (7.866 ms) : 0, 7866
Flare Poller [baseline] (3.65 ms) : 0, 3650
Flare Poller [candidate] (3.635 ms) : 0, 3635
ProfilingAgent [baseline] (93.822 ms) : 0, 93822
ProfilingAgent [candidate] (93.98 ms) : 0, 93980
Profiling [baseline] (94.394 ms) : 0, 94394
Profiling [candidate] (94.547 ms) : 0, 94547
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~a65abcd552, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056252
Total [baseline] (8.887 s) : 0, 8886739
Agent [candidate] (1.065 s) : 0, 1065120
Total [candidate] (8.876 s) : 0, 8875928
section iast
Agent [baseline] (1.223 s) : 0, 1222714
Total [baseline] (9.55 s) : 0, 9550201
Agent [candidate] (1.224 s) : 0, 1224053
Total [candidate] (9.547 s) : 0, 9546971
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~a65abcd552, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (633.264 ms) : 0, 633264
BytebuddyAgent [candidate] (639.45 ms) : 0, 639450
AgentMeter [baseline] (29.468 ms) : 0, 29468
AgentMeter [candidate] (29.786 ms) : 0, 29786
GlobalTracer [baseline] (249.054 ms) : 0, 249054
GlobalTracer [candidate] (249.609 ms) : 0, 249609
AppSec [baseline] (32.025 ms) : 0, 32025
AppSec [candidate] (32.197 ms) : 0, 32197
Debugger [baseline] (59.586 ms) : 0, 59586
Debugger [candidate] (59.578 ms) : 0, 59578
Remote Config [baseline] (602.929 µs) : 0, 603
Remote Config [candidate] (614.31 µs) : 0, 614
Telemetry [baseline] (8.096 ms) : 0, 8096
Telemetry [candidate] (7.972 ms) : 0, 7972
Flare Poller [baseline] (6.675 ms) : 0, 6675
Flare Poller [candidate] (8.198 ms) : 0, 8198
section iast
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (800.76 ms) : 0, 800760
BytebuddyAgent [candidate] (801.156 ms) : 0, 801156
AgentMeter [baseline] (11.353 ms) : 0, 11353
AgentMeter [candidate] (11.421 ms) : 0, 11421
GlobalTracer [baseline] (238.756 ms) : 0, 238756
GlobalTracer [candidate] (239.42 ms) : 0, 239420
AppSec [baseline] (30.904 ms) : 0, 30904
AppSec [candidate] (30.305 ms) : 0, 30305
Debugger [baseline] (57.541 ms) : 0, 57541
Debugger [candidate] (59.082 ms) : 0, 59082
Remote Config [baseline] (520.741 µs) : 0, 521
Remote Config [candidate] (519.389 µs) : 0, 519
Telemetry [baseline] (14.544 ms) : 0, 14544
Telemetry [candidate] (14.538 ms) : 0, 14538
Flare Poller [baseline] (3.778 ms) : 0, 3778
Flare Poller [candidate] (4.134 ms) : 0, 4134
IAST [baseline] (26.641 ms) : 0, 26641
IAST [candidate] (25.874 ms) : 0, 25874
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~a65abcd552, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (18.341 ms) : 18155, 18528
. : milestone, 18341,
appsec (18.403 ms) : 18219, 18587
. : milestone, 18403,
code_origins (18.192 ms) : 18010, 18374
. : milestone, 18192,
iast (17.808 ms) : 17633, 17984
. : milestone, 17808,
profiling (18.599 ms) : 18414, 18783
. : milestone, 18599,
tracing (17.986 ms) : 17808, 18165
. : milestone, 17986,
section candidate
no_agent (18.186 ms) : 17998, 18373
. : milestone, 18186,
appsec (18.567 ms) : 18380, 18754
. : milestone, 18567,
code_origins (17.904 ms) : 17723, 18085
. : milestone, 17904,
iast (17.975 ms) : 17794, 18157
. : milestone, 17975,
profiling (19.827 ms) : 19631, 20022
. : milestone, 19827,
tracing (17.772 ms) : 17597, 17948
. : milestone, 17772,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~a65abcd552, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (1.257 ms) : 1244, 1269
. : milestone, 1257,
iast (3.42 ms) : 3372, 3467
. : milestone, 3420,
iast_FULL (5.962 ms) : 5902, 6022
. : milestone, 5962,
iast_GLOBAL (3.549 ms) : 3499, 3600
. : milestone, 3549,
profiling (2.189 ms) : 2167, 2210
. : milestone, 2189,
tracing (1.863 ms) : 1847, 1878
. : milestone, 1863,
section candidate
no_agent (1.275 ms) : 1262, 1287
. : milestone, 1275,
iast (3.345 ms) : 3294, 3396
. : milestone, 3345,
iast_FULL (6.292 ms) : 6228, 6357
. : milestone, 6292,
iast_GLOBAL (3.581 ms) : 3521, 3641
. : milestone, 3581,
profiling (2.298 ms) : 2275, 2320
. : milestone, 2298,
tracing (1.86 ms) : 1844, 1876
. : milestone, 1860,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~a65abcd552, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (1.492 ms) : 1481, 1504
. : milestone, 1492,
appsec (3.837 ms) : 3613, 4062
. : milestone, 3837,
iast (2.281 ms) : 2212, 2349
. : milestone, 2281,
iast_GLOBAL (2.334 ms) : 2264, 2404
. : milestone, 2334,
profiling (2.107 ms) : 2052, 2163
. : milestone, 2107,
tracing (2.085 ms) : 2032, 2138
. : milestone, 2085,
section candidate
no_agent (1.495 ms) : 1484, 1507
. : milestone, 1495,
appsec (3.831 ms) : 3609, 4053
. : milestone, 3831,
iast (2.28 ms) : 2211, 2349
. : milestone, 2280,
iast_GLOBAL (2.327 ms) : 2258, 2397
. : milestone, 2327,
profiling (2.116 ms) : 2061, 2171
. : milestone, 2116,
tracing (2.097 ms) : 2043, 2151
. : milestone, 2097,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~a65abcd552, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (14.894 s) : 14894000, 14894000
. : milestone, 14894000,
appsec (14.815 s) : 14815000, 14815000
. : milestone, 14815000,
iast (18.378 s) : 18378000, 18378000
. : milestone, 18378000,
iast_GLOBAL (17.81 s) : 17810000, 17810000
. : milestone, 17810000,
profiling (14.958 s) : 14958000, 14958000
. : milestone, 14958000,
tracing (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
section candidate
no_agent (15.094 s) : 15094000, 15094000
. : milestone, 15094000,
appsec (14.626 s) : 14626000, 14626000
. : milestone, 14626000,
iast (18.185 s) : 18185000, 18185000
. : milestone, 18185000,
iast_GLOBAL (17.758 s) : 17758000, 17758000
. : milestone, 17758000,
profiling (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
tracing (14.78 s) : 14780000, 14780000
. : milestone, 14780000,
|
c0f3e8a to
8348f9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This pull request introduces two changes to crash tracking:
DD_CRASHTRACKING_EXTENDED_INFO_ENABLED-agentliband-javaagentkeydirectly, increasing coverage and removing the need for composite term matching.Motivation
The changes improve the robustness and security of crash tracking by ensuring sensitive data is not inadvertently exposed and streamlining key filtering logic to handle a broader range of system properties.
This restricts even more what was sent after #11013 during a crash.