emit SpanNode and TaskBlock events for critical-path analysis#11050
Draft
emit SpanNode and TaskBlock events for critical-path analysis#11050
Conversation
… to DatadogProfiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Introduces two new JFR event types emitted by the Datadog profiler to capture the causal structure of traced requests:
LockSupport.park()blocking interval that occurs under an active spanLockSupportProfilingInstrumentationmodule that instrumentsLockSupport.park*/unparkto capture these edges.Motivation
To improve latency attribution, critical-path analysis seems the way to go. It requires knowing which thread is the bottleneck for a given request at each point in time.
SpanNode and TaskBlock events together allow the backend to reconstruct the full execution DAG of a trace: SpanNode provides the span tree structure with precise timing, and TaskBlock provides the inter-thread wakeup edges (
park->unpark) needed to identify which thread is on the critical path.LockSupport.park/unparkis the foundation of most JVM blocking primitives (ReentrantLock,CountDownLatch,CompletableFuture, virtual threads), so instrumenting it captures the majority of inter-thread handoffs in practice.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-12146
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.