Migrate dd-trace-core groovy files to java part 1#11053
Open
Migrate dd-trace-core groovy files to java part 1#11053
Conversation
Migrate dd-trace-core module from Groovy to Java, using the /migrate-groovy-to-java Claude skill. This is part 1 with five file changes with no dependencies.
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
jpbempel
commented
Apr 3, 2026
Comment on lines
-22
to
-35
| // This fails because RemoteWriter isn't an interface and the mock doesn't prevent the call. | ||
| @Ignore | ||
| def "test onStart"() { | ||
| setup: | ||
| def writer = Mock(RemoteWriter) | ||
| def capacity = ThreadLocalRandom.current().nextInt() | ||
|
|
||
| when: | ||
| healthMetrics.onStart(writer) | ||
|
|
||
| then: | ||
| 1 * writer.getCapacity() >> capacity | ||
| 0 * _ | ||
| } |
Member
Author
There was a problem hiding this comment.
this test was removed during the migration. This test as been silented for 6 years now.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~328d9c82bc, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074674
Total [baseline] (8.872 s) : 0, 8871929
Agent [candidate] (1.062 s) : 0, 1061885
Total [candidate] (8.853 s) : 0, 8852948
section iast
Agent [baseline] (1.237 s) : 0, 1237446
Total [baseline] (9.571 s) : 0, 9571219
Agent [candidate] (1.236 s) : 0, 1236238
Total [candidate] (9.608 s) : 0, 9607581
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~328d9c82bc, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (639.973 ms) : 0, 639973
BytebuddyAgent [candidate] (633.175 ms) : 0, 633175
AgentMeter [baseline] (29.998 ms) : 0, 29998
AgentMeter [candidate] (29.292 ms) : 0, 29292
GlobalTracer [baseline] (256.849 ms) : 0, 256849
GlobalTracer [candidate] (254.199 ms) : 0, 254199
AppSec [baseline] (32.414 ms) : 0, 32414
AppSec [candidate] (32.01 ms) : 0, 32010
Debugger [baseline] (59.998 ms) : 0, 59998
Debugger [candidate] (59.474 ms) : 0, 59474
Remote Config [baseline] (617.203 µs) : 0, 617
Remote Config [candidate] (601.193 µs) : 0, 601
Telemetry [baseline] (8.229 ms) : 0, 8229
Telemetry [candidate] (8.185 ms) : 0, 8185
Flare Poller [baseline] (9.009 ms) : 0, 9009
Flare Poller [candidate] (7.449 ms) : 0, 7449
section iast
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (808.229 ms) : 0, 808229
BytebuddyAgent [candidate] (806.134 ms) : 0, 806134
AgentMeter [baseline] (11.526 ms) : 0, 11526
AgentMeter [candidate] (11.605 ms) : 0, 11605
GlobalTracer [baseline] (244.742 ms) : 0, 244742
GlobalTracer [candidate] (245.013 ms) : 0, 245013
AppSec [baseline] (32.006 ms) : 0, 32006
AppSec [candidate] (32.834 ms) : 0, 32834
Debugger [baseline] (57.641 ms) : 0, 57641
Debugger [candidate] (57.287 ms) : 0, 57287
Remote Config [baseline] (526.704 µs) : 0, 527
Remote Config [candidate] (528.829 µs) : 0, 529
Telemetry [baseline] (15.152 ms) : 0, 15152
Telemetry [candidate] (15.138 ms) : 0, 15138
Flare Poller [baseline] (3.468 ms) : 0, 3468
Flare Poller [candidate] (4.05 ms) : 0, 4050
IAST [baseline] (25.972 ms) : 0, 25972
IAST [candidate] (26.061 ms) : 0, 26061
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~328d9c82bc, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064821
Total [baseline] (11.078 s) : 0, 11078340
Agent [candidate] (1.069 s) : 0, 1068847
Total [candidate] (11.078 s) : 0, 11077880
section appsec
Agent [baseline] (1.256 s) : 0, 1255570
Total [baseline] (11.117 s) : 0, 11116571
Agent [candidate] (1.253 s) : 0, 1253149
Total [candidate] (11.102 s) : 0, 11101778
section iast
Agent [baseline] (1.237 s) : 0, 1237460
Total [baseline] (11.424 s) : 0, 11423665
Agent [candidate] (1.231 s) : 0, 1231294
Total [candidate] (11.346 s) : 0, 11345735
section profiling
Agent [baseline] (1.19 s) : 0, 1190069
Total [baseline] (11.063 s) : 0, 11063158
Agent [candidate] (1.19 s) : 0, 1190401
Total [candidate] (11.123 s) : 0, 11122658
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~328d9c82bc, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (633.911 ms) : 0, 633911
BytebuddyAgent [candidate] (637.527 ms) : 0, 637527
AgentMeter [baseline] (29.472 ms) : 0, 29472
AgentMeter [candidate] (29.743 ms) : 0, 29743
GlobalTracer [baseline] (255.119 ms) : 0, 255119
GlobalTracer [candidate] (256.075 ms) : 0, 256075
AppSec [baseline] (32.218 ms) : 0, 32218
AppSec [candidate] (32.24 ms) : 0, 32240
Debugger [baseline] (60.344 ms) : 0, 60344
Debugger [candidate] (60.256 ms) : 0, 60256
Remote Config [baseline] (598.367 µs) : 0, 598
Remote Config [candidate] (628.352 µs) : 0, 628
Telemetry [baseline] (8.076 ms) : 0, 8076
Telemetry [candidate] (8.124 ms) : 0, 8124
Flare Poller [baseline] (7.577 ms) : 0, 7577
Flare Poller [candidate] (6.736 ms) : 0, 6736
section appsec
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (663.106 ms) : 0, 663106
BytebuddyAgent [candidate] (661.748 ms) : 0, 661748
AgentMeter [baseline] (12.076 ms) : 0, 12076
AgentMeter [candidate] (12.146 ms) : 0, 12146
GlobalTracer [baseline] (254.78 ms) : 0, 254780
GlobalTracer [candidate] (254.593 ms) : 0, 254593
AppSec [baseline] (184.147 ms) : 0, 184147
AppSec [candidate] (183.779 ms) : 0, 183779
Debugger [baseline] (65.35 ms) : 0, 65350
Debugger [candidate] (65.94 ms) : 0, 65940
Remote Config [baseline] (609.437 µs) : 0, 609
Remote Config [candidate] (602.494 µs) : 0, 602
Telemetry [baseline] (9.543 ms) : 0, 9543
Telemetry [candidate] (8.685 ms) : 0, 8685
Flare Poller [baseline] (3.581 ms) : 0, 3581
Flare Poller [candidate] (3.549 ms) : 0, 3549
IAST [baseline] (24.648 ms) : 0, 24648
IAST [candidate] (24.541 ms) : 0, 24541
section iast
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (805.371 ms) : 0, 805371
BytebuddyAgent [candidate] (802.121 ms) : 0, 802121
AgentMeter [baseline] (11.479 ms) : 0, 11479
AgentMeter [candidate] (11.416 ms) : 0, 11416
GlobalTracer [baseline] (246.927 ms) : 0, 246927
GlobalTracer [candidate] (244.758 ms) : 0, 244758
AppSec [baseline] (31.354 ms) : 0, 31354
AppSec [candidate] (31.742 ms) : 0, 31742
Debugger [baseline] (58.265 ms) : 0, 58265
Debugger [candidate] (58.29 ms) : 0, 58290
Remote Config [baseline] (529.696 µs) : 0, 530
Remote Config [candidate] (511.68 µs) : 0, 512
Telemetry [baseline] (15.036 ms) : 0, 15036
Telemetry [candidate] (15.004 ms) : 0, 15004
Flare Poller [baseline] (4.03 ms) : 0, 4030
Flare Poller [candidate] (3.876 ms) : 0, 3876
IAST [baseline] (27.008 ms) : 0, 27008
IAST [candidate] (25.905 ms) : 0, 25905
section profiling
crashtracking [baseline] (1.172 ms) : 0, 1172
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (691.77 ms) : 0, 691770
BytebuddyAgent [candidate] (691.785 ms) : 0, 691785
AgentMeter [baseline] (9.132 ms) : 0, 9132
AgentMeter [candidate] (9.103 ms) : 0, 9103
GlobalTracer [baseline] (212.381 ms) : 0, 212381
GlobalTracer [candidate] (212.506 ms) : 0, 212506
AppSec [baseline] (32.546 ms) : 0, 32546
AppSec [candidate] (32.487 ms) : 0, 32487
Debugger [baseline] (65.812 ms) : 0, 65812
Debugger [candidate] (65.698 ms) : 0, 65698
Remote Config [baseline] (582.915 µs) : 0, 583
Remote Config [candidate] (573.789 µs) : 0, 574
Telemetry [baseline] (7.814 ms) : 0, 7814
Telemetry [candidate] (7.904 ms) : 0, 7904
Flare Poller [baseline] (3.536 ms) : 0, 3536
Flare Poller [candidate] (3.558 ms) : 0, 3558
ProfilingAgent [baseline] (93.957 ms) : 0, 93957
ProfilingAgent [candidate] (93.998 ms) : 0, 93998
Profiling [baseline] (94.529 ms) : 0, 94529
Profiling [candidate] (94.581 ms) : 0, 94581
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~328d9c82bc, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (1.26 ms) : 1247, 1272
. : milestone, 1260,
iast (3.357 ms) : 3308, 3406
. : milestone, 3357,
iast_FULL (5.874 ms) : 5815, 5933
. : milestone, 5874,
iast_GLOBAL (3.629 ms) : 3569, 3689
. : milestone, 3629,
profiling (2.169 ms) : 2149, 2188
. : milestone, 2169,
tracing (1.87 ms) : 1855, 1885
. : milestone, 1870,
section candidate
no_agent (1.261 ms) : 1249, 1273
. : milestone, 1261,
iast (3.338 ms) : 3292, 3385
. : milestone, 3338,
iast_FULL (5.913 ms) : 5854, 5972
. : milestone, 5913,
iast_GLOBAL (3.641 ms) : 3582, 3700
. : milestone, 3641,
profiling (2.141 ms) : 2123, 2160
. : milestone, 2141,
tracing (1.915 ms) : 1898, 1933
. : milestone, 1915,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~328d9c82bc, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (19.389 ms) : 19187, 19591
. : milestone, 19389,
appsec (18.5 ms) : 18313, 18688
. : milestone, 18500,
code_origins (17.822 ms) : 17642, 18002
. : milestone, 17822,
iast (17.833 ms) : 17658, 18009
. : milestone, 17833,
profiling (18.692 ms) : 18510, 18874
. : milestone, 18692,
tracing (17.663 ms) : 17490, 17836
. : milestone, 17663,
section candidate
no_agent (19.196 ms) : 18997, 19394
. : milestone, 19196,
appsec (18.777 ms) : 18589, 18965
. : milestone, 18777,
code_origins (18.9 ms) : 18708, 19093
. : milestone, 18900,
iast (18.003 ms) : 17828, 18179
. : milestone, 18003,
profiling (18.562 ms) : 18377, 18747
. : milestone, 18562,
tracing (18.585 ms) : 18395, 18774
. : milestone, 18585,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~328d9c82bc, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.802 ms) : 3580, 4024
. : milestone, 3802,
iast (2.262 ms) : 2193, 2330
. : milestone, 2262,
iast_GLOBAL (2.297 ms) : 2228, 2367
. : milestone, 2297,
profiling (2.088 ms) : 2033, 2142
. : milestone, 2088,
tracing (2.063 ms) : 2010, 2117
. : milestone, 2063,
section candidate
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (3.746 ms) : 3529, 3964
. : milestone, 3746,
iast (2.267 ms) : 2197, 2336
. : milestone, 2267,
iast_GLOBAL (2.317 ms) : 2247, 2387
. : milestone, 2317,
profiling (2.102 ms) : 2046, 2158
. : milestone, 2102,
tracing (2.077 ms) : 2023, 2131
. : milestone, 2077,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~328d9c82bc, baseline=1.61.0-SNAPSHOT~cd5b227eb2
dateFormat X
axisFormat %s
section baseline
no_agent (15.572 s) : 15572000, 15572000
. : milestone, 15572000,
appsec (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
iast (18.153 s) : 18153000, 18153000
. : milestone, 18153000,
iast_GLOBAL (17.979 s) : 17979000, 17979000
. : milestone, 17979000,
profiling (14.864 s) : 14864000, 14864000
. : milestone, 14864000,
tracing (14.83 s) : 14830000, 14830000
. : milestone, 14830000,
section candidate
no_agent (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
appsec (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
iast (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
iast_GLOBAL (18.032 s) : 18032000, 18032000
. : milestone, 18032000,
profiling (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
tracing (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
|
sarahchen6
added
comp: testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Migrate
dd-trace-coremodule from Groovy to Java, using the /migrate-groovy-to-java Claude skill. This is part 1 with five file changes with no dependencies.Motivation
this is part of the effort to migrate groovy tests to Java/JUnit
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.