Guarantee OTel Configs to run through ConfigHelper#11057
Guarantee OTel Configs to run through ConfigHelper#11057gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
ConfigHelper#11057Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~5b110b1ac0, baseline=1.61.0-SNAPSHOT~b664cc0f2a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053482
Total [baseline] (8.82 s) : 0, 8820207
Agent [candidate] (1.055 s) : 0, 1055123
Total [candidate] (8.817 s) : 0, 8817246
section iast
Agent [baseline] (1.224 s) : 0, 1224093
Total [baseline] (9.52 s) : 0, 9520160
Agent [candidate] (1.219 s) : 0, 1219252
Total [candidate] (9.55 s) : 0, 9549552
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~5b110b1ac0, baseline=1.61.0-SNAPSHOT~b664cc0f2a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.235 ms) : 0, 1235
crashtracking [candidate] (1.226 ms) : 0, 1226
BytebuddyAgent [baseline] (631.48 ms) : 0, 631480
BytebuddyAgent [candidate] (630.633 ms) : 0, 630633
AgentMeter [baseline] (29.384 ms) : 0, 29384
AgentMeter [candidate] (29.357 ms) : 0, 29357
GlobalTracer [baseline] (248.271 ms) : 0, 248271
GlobalTracer [candidate] (248.323 ms) : 0, 248323
AppSec [baseline] (31.97 ms) : 0, 31970
AppSec [candidate] (31.813 ms) : 0, 31813
Debugger [baseline] (58.958 ms) : 0, 58958
Debugger [candidate] (58.831 ms) : 0, 58831
Remote Config [baseline] (634.464 µs) : 0, 634
Remote Config [candidate] (594.893 µs) : 0, 595
Telemetry [baseline] (8.058 ms) : 0, 8058
Telemetry [candidate] (8.02 ms) : 0, 8020
Flare Poller [baseline] (7.331 ms) : 0, 7331
Flare Poller [candidate] (10.279 ms) : 0, 10279
section iast
crashtracking [baseline] (1.233 ms) : 0, 1233
crashtracking [candidate] (1.235 ms) : 0, 1235
BytebuddyAgent [baseline] (802.639 ms) : 0, 802639
BytebuddyAgent [candidate] (798.563 ms) : 0, 798563
AgentMeter [baseline] (11.362 ms) : 0, 11362
AgentMeter [candidate] (11.329 ms) : 0, 11329
GlobalTracer [baseline] (238.701 ms) : 0, 238701
GlobalTracer [candidate] (238.642 ms) : 0, 238642
AppSec [baseline] (31.692 ms) : 0, 31692
AppSec [candidate] (31.642 ms) : 0, 31642
Debugger [baseline] (57.279 ms) : 0, 57279
Debugger [candidate] (56.23 ms) : 0, 56230
Remote Config [baseline] (530.018 µs) : 0, 530
Remote Config [candidate] (511.62 µs) : 0, 512
Telemetry [baseline] (13.785 ms) : 0, 13785
Telemetry [candidate] (13.873 ms) : 0, 13873
Flare Poller [baseline] (4.745 ms) : 0, 4745
Flare Poller [candidate] (4.675 ms) : 0, 4675
IAST [baseline] (25.746 ms) : 0, 25746
IAST [candidate] (26.568 ms) : 0, 26568
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~5b110b1ac0, baseline=1.61.0-SNAPSHOT~b664cc0f2a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052980
Total [baseline] (11.079 s) : 0, 11078572
Agent [candidate] (1.068 s) : 0, 1067922
Total [candidate] (11.132 s) : 0, 11131826
section appsec
Agent [baseline] (1.247 s) : 0, 1246559
Total [baseline] (11.04 s) : 0, 11040199
Agent [candidate] (1.247 s) : 0, 1247249
Total [candidate] (11.127 s) : 0, 11127152
section iast
Agent [baseline] (1.222 s) : 0, 1221994
Total [baseline] (11.243 s) : 0, 11242629
Agent [candidate] (1.221 s) : 0, 1220541
Total [candidate] (11.256 s) : 0, 11256078
section profiling
Agent [baseline] (1.189 s) : 0, 1188769
Total [baseline] (11.145 s) : 0, 11145274
Agent [candidate] (1.191 s) : 0, 1190964
Total [candidate] (11.12 s) : 0, 11120445
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~5b110b1ac0, baseline=1.61.0-SNAPSHOT~b664cc0f2a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.233 ms) : 0, 1233
crashtracking [candidate] (1.244 ms) : 0, 1244
BytebuddyAgent [baseline] (630.885 ms) : 0, 630885
BytebuddyAgent [candidate] (640.187 ms) : 0, 640187
AgentMeter [baseline] (29.329 ms) : 0, 29329
AgentMeter [candidate] (29.901 ms) : 0, 29901
GlobalTracer [baseline] (248.545 ms) : 0, 248545
GlobalTracer [candidate] (251.694 ms) : 0, 251694
AppSec [baseline] (31.906 ms) : 0, 31906
AppSec [candidate] (32.484 ms) : 0, 32484
Debugger [baseline] (59.749 ms) : 0, 59749
Debugger [candidate] (60.678 ms) : 0, 60678
Remote Config [baseline] (601.883 µs) : 0, 602
Remote Config [candidate] (603.595 µs) : 0, 604
Telemetry [baseline] (8.069 ms) : 0, 8069
Telemetry [candidate] (8.206 ms) : 0, 8206
Flare Poller [baseline] (6.538 ms) : 0, 6538
Flare Poller [candidate] (6.671 ms) : 0, 6671
section appsec
crashtracking [baseline] (1.232 ms) : 0, 1232
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (661.669 ms) : 0, 661669
BytebuddyAgent [candidate] (661.065 ms) : 0, 661065
AgentMeter [baseline] (12.07 ms) : 0, 12070
AgentMeter [candidate] (12.127 ms) : 0, 12127
GlobalTracer [baseline] (248.485 ms) : 0, 248485
GlobalTracer [candidate] (248.885 ms) : 0, 248885
AppSec [baseline] (183.688 ms) : 0, 183688
AppSec [candidate] (184.207 ms) : 0, 184207
Debugger [baseline] (65.655 ms) : 0, 65655
Debugger [candidate] (66.049 ms) : 0, 66049
Remote Config [baseline] (619.041 µs) : 0, 619
Remote Config [candidate] (596.558 µs) : 0, 597
Telemetry [baseline] (8.681 ms) : 0, 8681
Telemetry [candidate] (8.714 ms) : 0, 8714
Flare Poller [baseline] (3.493 ms) : 0, 3493
Flare Poller [candidate] (3.531 ms) : 0, 3531
IAST [baseline] (24.568 ms) : 0, 24568
IAST [candidate] (24.533 ms) : 0, 24533
section iast
crashtracking [baseline] (1.244 ms) : 0, 1244
crashtracking [candidate] (1.242 ms) : 0, 1242
BytebuddyAgent [baseline] (799.704 ms) : 0, 799704
BytebuddyAgent [candidate] (798.257 ms) : 0, 798257
AgentMeter [baseline] (11.374 ms) : 0, 11374
AgentMeter [candidate] (11.385 ms) : 0, 11385
GlobalTracer [baseline] (238.665 ms) : 0, 238665
GlobalTracer [candidate] (238.528 ms) : 0, 238528
AppSec [baseline] (30.727 ms) : 0, 30727
AppSec [candidate] (30.167 ms) : 0, 30167
Debugger [baseline] (58.359 ms) : 0, 58359
Debugger [candidate] (59.851 ms) : 0, 59851
Remote Config [baseline] (537.185 µs) : 0, 537
Remote Config [candidate] (532.279 µs) : 0, 532
Telemetry [baseline] (14.004 ms) : 0, 14004
Telemetry [candidate] (13.894 ms) : 0, 13894
Flare Poller [baseline] (4.515 ms) : 0, 4515
Flare Poller [candidate] (4.859 ms) : 0, 4859
IAST [baseline] (26.636 ms) : 0, 26636
IAST [candidate] (25.804 ms) : 0, 25804
section profiling
ProfilingAgent [baseline] (94.006 ms) : 0, 94006
ProfilingAgent [candidate] (94.441 ms) : 0, 94441
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (694.437 ms) : 0, 694437
BytebuddyAgent [candidate] (695.797 ms) : 0, 695797
AgentMeter [baseline] (9.147 ms) : 0, 9147
AgentMeter [candidate] (9.153 ms) : 0, 9153
GlobalTracer [baseline] (207.65 ms) : 0, 207650
GlobalTracer [candidate] (207.869 ms) : 0, 207869
AppSec [baseline] (32.762 ms) : 0, 32762
AppSec [candidate] (32.768 ms) : 0, 32768
Debugger [baseline] (66.13 ms) : 0, 66130
Debugger [candidate] (66.14 ms) : 0, 66140
Remote Config [baseline] (571.327 µs) : 0, 571
Remote Config [candidate] (575.673 µs) : 0, 576
Telemetry [baseline] (7.838 ms) : 0, 7838
Telemetry [candidate] (7.82 ms) : 0, 7820
Flare Poller [baseline] (3.582 ms) : 0, 3582
Flare Poller [candidate] (3.576 ms) : 0, 3576
Profiling [baseline] (94.567 ms) : 0, 94567
Profiling [candidate] (95.008 ms) : 0, 95008
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~5b110b1ac0, baseline=1.61.0-SNAPSHOT~b664cc0f2a
dateFormat X
axisFormat %s
section baseline
no_agent (19.47 ms) : 19273, 19667
. : milestone, 19470,
appsec (18.625 ms) : 18433, 18816
. : milestone, 18625,
code_origins (17.903 ms) : 17728, 18078
. : milestone, 17903,
iast (18.077 ms) : 17899, 18255
. : milestone, 18077,
profiling (18.9 ms) : 18711, 19089
. : milestone, 18900,
tracing (17.874 ms) : 17697, 18051
. : milestone, 17874,
section candidate
no_agent (18.846 ms) : 18655, 19037
. : milestone, 18846,
appsec (18.655 ms) : 18467, 18844
. : milestone, 18655,
code_origins (17.858 ms) : 17683, 18033
. : milestone, 17858,
iast (18.824 ms) : 18632, 19016
. : milestone, 18824,
profiling (18.524 ms) : 18342, 18706
. : milestone, 18524,
tracing (17.768 ms) : 17595, 17942
. : milestone, 17768,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~5b110b1ac0, baseline=1.61.0-SNAPSHOT~b664cc0f2a
dateFormat X
axisFormat %s
section baseline
no_agent (1.252 ms) : 1240, 1264
. : milestone, 1252,
iast (3.395 ms) : 3355, 3436
. : milestone, 3395,
iast_FULL (5.788 ms) : 5730, 5847
. : milestone, 5788,
iast_GLOBAL (3.964 ms) : 3897, 4031
. : milestone, 3964,
profiling (2.146 ms) : 2127, 2166
. : milestone, 2146,
tracing (1.873 ms) : 1857, 1888
. : milestone, 1873,
section candidate
no_agent (1.249 ms) : 1237, 1260
. : milestone, 1249,
iast (3.265 ms) : 3215, 3314
. : milestone, 3265,
iast_FULL (5.925 ms) : 5864, 5985
. : milestone, 5925,
iast_GLOBAL (3.63 ms) : 3577, 3683
. : milestone, 3630,
profiling (2.219 ms) : 2197, 2241
. : milestone, 2219,
tracing (1.886 ms) : 1871, 1901
. : milestone, 1886,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~5b110b1ac0, baseline=1.61.0-SNAPSHOT~b664cc0f2a
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.813 ms) : 3590, 4035
. : milestone, 3813,
iast (2.269 ms) : 2200, 2338
. : milestone, 2269,
iast_GLOBAL (2.303 ms) : 2234, 2371
. : milestone, 2303,
profiling (2.111 ms) : 2054, 2167
. : milestone, 2111,
tracing (2.087 ms) : 2034, 2141
. : milestone, 2087,
section candidate
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (3.763 ms) : 3545, 3981
. : milestone, 3763,
iast (2.269 ms) : 2200, 2338
. : milestone, 2269,
iast_GLOBAL (2.299 ms) : 2230, 2369
. : milestone, 2299,
profiling (2.091 ms) : 2036, 2146
. : milestone, 2091,
tracing (2.065 ms) : 2011, 2118
. : milestone, 2065,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~5b110b1ac0, baseline=1.61.0-SNAPSHOT~b664cc0f2a
dateFormat X
axisFormat %s
section baseline
no_agent (15.474 s) : 15474000, 15474000
. : milestone, 15474000,
appsec (14.831 s) : 14831000, 14831000
. : milestone, 14831000,
iast (18.447 s) : 18447000, 18447000
. : milestone, 18447000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
profiling (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
tracing (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
section candidate
no_agent (15.535 s) : 15535000, 15535000
. : milestone, 15535000,
appsec (14.741 s) : 14741000, 14741000
. : milestone, 14741000,
iast (18.562 s) : 18562000, 18562000
. : milestone, 18562000,
iast_GLOBAL (17.986 s) : 17986000, 17986000
. : milestone, 17986000,
profiling (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
tracing (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
70b27c7
into
master
What Does This Do
Currently, OTel configs prioritize system properties over environment variables. If system properties are set, environment variables are not queried. This means that we would not be able to track all OTel configs that we support since the flow needs to enter ConfigHelper to ensure that all configs are documented (done in #11031). Side note: this should also make config telemetry for OTel configs more complete as we would report both environment variables and system properties.
This PR reverses the order of querying to first query environment variables and then system properties for OTel configs. Like before, system properties will still take priority.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.