ci: add node 26 to asan and valgrind matrices#321
Closed
jimexist wants to merge 1 commit into
Closed
Conversation
jimexist
requested review from
IlyasShabi,
nsavoire,
r1viollet and
szegedi
as code owners
|
Thanks for this PR. Actually Node.js comes with V8 14.6 and some breaking changes. I already created two PRs to support Node.js on Nan and node-gyp: |
Author
|
thanks for the progress @IlyasShabi i wonder if now this PR is ready to run? |
jimexist
force-pushed
the
claude/vibrant-bardeen-9f6cd4
branch
2 times, most recently
from
511e4d2 to
f3efdf2
Compare
Merged
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jimexist
force-pushed
the
claude/vibrant-bardeen-9f6cd4
branch
from
f3efdf2 to
efb29a2
Compare
|
I managed to have v26 supported in #327. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asanandvalgrindjob matrices in.github/workflows/build.ymlso CI exercises the latest Node release line.Test plan
asanandvalgrindjobs.🤖 Generated with Claude Code