Skip to content

Move devextreme-dist workspace to packages/#33150

Open
alexslavr wants to merge 1 commit into26_1from
lavrov/devextreme-dist-package
Open

Move devextreme-dist workspace to packages/#33150
alexslavr wants to merge 1 commit into26_1from
lavrov/devextreme-dist-package

Conversation

@alexslavr
Copy link
Copy Markdown
Contributor

No description provided.

@alexslavr alexslavr self-assigned this Apr 3, 2026
@alexslavr alexslavr marked this pull request as ready for review April 3, 2026 12:19
Copilot AI review requested due to automatic review settings April 3, 2026 12:19
@alexslavr alexslavr changed the title Add devextreme-dist package and update related configurations Move devextreme-dist workspace to packages/ Apr 3, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR transitions devextreme-dist from being treated as an artifacts-folder workspace package into a dedicated workspace package (packages/devextreme-dist) and updates the build/packaging pipeline to generate the published devextreme-dist package.json during the DevExtreme npm build.

Changes:

  • Removed packages/devextreme/artifacts/npm/devextreme-dist from pnpm workspaces and lockfile importers; added packages/devextreme-dist as the workspace publisher entry.
  • Updated DevExtreme npm build gulp task to source devextreme-dist metadata from packages/devextreme-dist/package.json and emit it into artifacts/npm/devextreme-dist with the correct version.
  • Updated clean/ignore/caching inputs so devextreme-dist’s artifacts package.json is no longer kept/committed and is regenerated from the workspace package.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-workspace.yaml Stops treating the artifacts devextreme-dist folder as a workspace package.
pnpm-lock.yaml Moves the pnpm “publisher directory” mapping from the artifacts folder to packages/devextreme-dist.
packages/devextreme/project.json Updates clean exclusions and Nx build inputs to track packages/devextreme-dist/package.json.
packages/devextreme/gulpfile.js Adjusts clean behavior so devextreme-dist JSON files in artifacts aren’t preserved.
packages/devextreme/build/gulp/npm.js Generates artifacts/npm/devextreme-dist/package.json from the workspace package, stamping version and removing publishConfig.
packages/devextreme/.gitignore Stops un-ignoring the artifacts devextreme-dist/package.json so it’s no longer committed.
packages/devextreme-dist/package.json Adds publishConfig for the new workspace package and fixes trailing whitespace.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants