Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR transitions devextreme-dist from being treated as an artifacts-folder workspace package into a dedicated workspace package (packages/devextreme-dist) and updates the build/packaging pipeline to generate the published devextreme-dist package.json during the DevExtreme npm build.
Changes:
- Removed
packages/devextreme/artifacts/npm/devextreme-distfrom pnpm workspaces and lockfile importers; addedpackages/devextreme-distas the workspace publisher entry. - Updated DevExtreme npm build gulp task to source
devextreme-distmetadata frompackages/devextreme-dist/package.jsonand emit it intoartifacts/npm/devextreme-distwith the correct version. - Updated clean/ignore/caching inputs so
devextreme-dist’s artifactspackage.jsonis no longer kept/committed and is regenerated from the workspace package.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Stops treating the artifacts devextreme-dist folder as a workspace package. |
| pnpm-lock.yaml | Moves the pnpm “publisher directory” mapping from the artifacts folder to packages/devextreme-dist. |
| packages/devextreme/project.json | Updates clean exclusions and Nx build inputs to track packages/devextreme-dist/package.json. |
| packages/devextreme/gulpfile.js | Adjusts clean behavior so devextreme-dist JSON files in artifacts aren’t preserved. |
| packages/devextreme/build/gulp/npm.js | Generates artifacts/npm/devextreme-dist/package.json from the workspace package, stamping version and removing publishConfig. |
| packages/devextreme/.gitignore | Stops un-ignoring the artifacts devextreme-dist/package.json so it’s no longer committed. |
| packages/devextreme-dist/package.json | Adds publishConfig for the new workspace package and fixes trailing whitespace. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.