ci: rename DevolutionsAgentUpdater with arch suffix to avoid duplicate release assets#1760
Merged
Benoît Cortier (CBenoit) merged 5 commits intomasterfrom Apr 20, 2026
Merged
Conversation
Benoît Cortier (CBenoit)
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CI/package workflows to rename the Windows Devolutions Agent Updater executable to an architecture-suffixed filename so GitHub Release asset uploads don’t collide between arm64 and x86_64.
Changes:
- Rename the updater artifact from
DevolutionsAgentUpdater.exetoDevolutionsAgentUpdater_<OS>_<version>_<arch>.exein the CI staging output. - Update packaging/code-signing workflows to reference
DevolutionsAgentUpdater_*.exeinstead of the unsuffixed filename. - Remove now-unnecessary OneDrive upload exclusions for the updater (since the filename becomes unique per arch).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Changes the staged updater filename to include OS/version/arch; adjusts OneDrive flattening exclusions accordingly. |
| .github/workflows/package.yml | Updates signing/MSI regeneration steps to look for the new updater filename pattern. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Richard Markiewicz (thenextman)
approved these changes
Apr 20, 2026
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
had a problem deploying
to
publish-prod
GitHub Actions
Error
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
had a problem deploying
to
publish-prod
GitHub Actions
Failure
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
had a problem deploying
to
publish-prod
GitHub Actions
Error
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e release assets DevolutionsAgentUpdater.exe is a new artifact that exists in both the arm64 and x86_64 output directories without an architecture suffix. When uploading to the GitHub release, gh uses the basename as the asset name, causing the second upload to fail with 'ReleaseAsset.name already exists'. Name the file DevolutionsAgentUpdater_Windows_\_\.exe, following the same convention already used for DevolutionsAgent_Windows_*.exe. Update all references in ci.yml and package.yml accordingly, and remove the now-unnecessary exclusions from the OneDrive upload flattening step.
…acts The Regenerate Agent MSI step defaults to x86_64 (tlk.ps1 architecture default) but was searching recursively across both arm64 and x86_64 directories, leaving the executable selection to chance via Select -First 1. Introduce an $x64Root variable pointing to windows\x86_64 and scope all per-architecture file lookups to that path. tun2socks and wintun are kept with a recursive search on the full PackageRoot since they live under a separate tun2socks\ subdirectory.
Benoît Cortier (CBenoit)
force-pushed
the
ci/fix-github-releases
branch
from
9a52e4c to
9a85d4f
Compare
Benoît Cortier (CBenoit)
had a problem deploying
to
publish-prod
GitHub Actions
Error
Benoît Cortier (CBenoit)
had a problem deploying
to
publish-prod
GitHub Actions
Failure
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
had a problem deploying
to
publish-prod
GitHub Actions
Error
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
had a problem deploying
to
publish-prod
GitHub Actions
Failure
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
had a problem deploying
to
sbom
GitHub Actions
Failure
Benoît Cortier (CBenoit)
had a problem deploying
to
onedrive-upload
GitHub Actions
Failure
Benoît Cortier (CBenoit)
had a problem deploying
to
onedrive-upload
GitHub Actions
Failure
Benoît Cortier (CBenoit)
temporarily deployed
to
publish-prod
GitHub Actions
Inactive
It is an internal MSI update helper bundled inside the installer, not a useful standalone download for end users.
Benoît Cortier (CBenoit)
force-pushed
the
ci/fix-github-releases
branch
from
00fa9c3 to
94837e5
Compare
Benoît Cortier (CBenoit)
force-pushed
the
ci/fix-github-releases
branch
from
dd84b6d to
aab8d09
Compare
When MSBuild runs /t:restore,build in a single invocation on a fresh runner without cached NuGet packages, the WixSharp.bin package .props file (which sets WixSharpBinPath) is not evaluated at project-load time (before restore runs). This leaves WixSharpBinPath empty, so /WIXBIN: is empty, and WixSharp throws 'WiX binaries cannot be found'. Fix by exporting WIXSHARP_WIXDIR via GITHUB_ENV in the Configure runner step. WixSharp checks this env var as a fallback at runtime, reliably finding WiX 3.14 binaries regardless of NuGet cache state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DevolutionsAgentUpdater.exe is a new artifact that exists in both the arm64 and x86_64 output directories without an architecture suffix. When uploading to the GitHub release, gh uses the basename as the asset name, causing the second upload to fail with 'ReleaseAsset.name already exists'.
Name the file DevolutionsAgentUpdater_Windows__.exe, following the same convention already used for DevolutionsAgent_Windows_*.exe. Update all references in ci.yml and package.yml accordingly, and remove the now-unnecessary exclusions from the OneDrive upload flattening step.