Skip to content

constpacket: use onion messages feature#9022

Open
rustyrussell wants to merge 4 commits intoElementsProject:masterfrom
rustyrussell:guilt/constpacket-use-onion-messages
Open

constpacket: use onion messages feature#9022
rustyrussell wants to merge 4 commits intoElementsProject:masterfrom
rustyrussell:guilt/constpacket-use-onion-messages

Conversation

@rustyrussell
Copy link
Copy Markdown
Contributor

@rustyrussell rustyrussell commented Apr 2, 2026

@sangbida had to yeet the constant message feature because of lightningnetwork/lnd#10671

But it's fixed in LND v21 (lightningnetwork/lnd#10674 ), and @Roasbeef also points out "For lnd 21 you should be able to check the Taproot final feature bit and/or the onion message bit".

And everyone else supports onion_messages, so...

Changelog-None: fixes feature introduced in this release.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We're about to use it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…N_MESSAGES.

I 🧡 Laolu!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This reverts:

2252bda "connectd: gate uniform message padding behind --dev-uniform-padding"
f844eb0 "lightningd: add dev-uniform-padding flag to lightningd".
b7c05f6 "test: add flag to test_constant_packet_size"

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell added this to the v26.04 milestone Apr 2, 2026
@rustyrussell rustyrussell added the 26.04 RC This PR needs to go into the next release candidate for 26.04 label Apr 2, 2026
Copy link
Copy Markdown
Collaborator

@Lagrang3 Lagrang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

26.04 RC This PR needs to go into the next release candidate for 26.04

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants